Code Monkey home page Code Monkey logo

Comments (4)

simonsarris avatar simonsarris commented on June 4, 2024

Possibly this is fixed in 2.3.16. Can you give it a try?

from gojs.

shollander avatar shollander commented on June 4, 2024

I still get esbuild warnings when using 2.3.16. The error is slightly different, but the idea is the same:

The CommonJS "module" variable is treated as a global variable in an ECMAScript module and may not work as expected [commonjs-variable-in-esm]

    node_modules/gojs/release/go-module.mjs:41685:74
        41685  |   'undefined' !== typeof module && 'object' === typeof module.exports && (module.exports = 'undefined' !== typeof global ? global.go : self.go);
               |                                                        ~~~~~~

I should mention that in order to see these warnings you need to run the build with the verbose flag (i.e. ng build --verbose).

from gojs.

simonsarris avatar simonsarris commented on June 4, 2024

We've changed this in the 3.0 (currently beta) branch, by removing any module.exports = ... from ESM files. We might change it for 2.3 also, but maybe not. It's difficult to make changes like this that may break some customer builds, however unlikely, so its a bit preferable to do it in a version bump.

3.0 will become the latest version soon.

from gojs.

simonsarris avatar simonsarris commented on June 4, 2024

If you want to try the 3.0 beta, 3.0.0-b7 has been released with this change.

npm i gojs@beta

from gojs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.