Code Monkey home page Code Monkey logo

Comments (2)

martinju avatar martinju commented on May 18, 2024

I am getting a bit worried that every time we make a change to shap or explain functions, we have to re-create the test objects (explanation_explain_obj.rds and similar) which compares the results of the previous run to pass the tests. That means we don't have a good test for this. This is especially dangerous if one does many changes in the same PR (although we seldom do that).

My suggestion is to add a seperate test that checks only the shapley values from the different test models. We could run a lapply call to the ex_list, extract only the data.table with the shapley values, and then do a testthat::expect_known_value or testthat::expect_known_object on that. What do you think @nikolase90 ? Or is there a better option?

from shapr.

nikolase90 avatar nikolase90 commented on May 18, 2024

@martinju I think that sounds like a good way to do it.

from shapr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.