Would be a good idea to have tests covering the library about android-scanner-compat-library HOT 6 CLOSED

Hi @aldoborrero

Currently I have a lot of things on my plate but I would happily accept any PR. As you wrote in the issue you mentioned here the tests should be pretty much similar to original ones. All help would be appreciated.

Also, the current version number is 0.2.0 but as I haven't got any issues for a long time now I think it should be then changed to 1.0.0.

from android-scanner-compat-library.

Cool @philips77 I'll try to add a PR as soon as I can. Thanks for your input!

from android-scanner-compat-library.

Hi, did you encounter any problems with the lib? Do you thing I should release the version 1.0.0 on jcenter? Do you use it from there, or have cloned it into your project?

from android-scanner-compat-library.

I've been using the lib some time ago and I found nothing wrong with it!

From my side point of view is good and safe to make 1.0.0 release (and if something arises will be minor bugs).

There's already a merge in RxAndroidBle that adds support for this library to use it underneath the reactive code. So if you feel more confident I can battle test even more this.

What I would like to add to next versions is more tests (those from AOSP doesn't cover too much I guess). So we can increase the code coverage of the project.

And... to add a checkstyle guide to standardise code commits if more people wants to collaborate.

from android-scanner-compat-library.

Hi, I've released the version 1.0.0 on jcenter now.

from android-scanner-compat-library.

Thanks @philips77 :)

from android-scanner-compat-library.