Comments (2)
The routing approach has changed with the use of closures, and the route matching loop invokes closures that contain the matching logic. This might be the main cause for this. Currently working on this to move out that logic to the top level loop.
from dispatch.
I've tested the before and after of #87, and got the following results:
I think the results are inconclusive, and could be attributed to margin of error. This was using php-cli's built in server, and 10 test routes.
Will be closing this, and we can revisit again if it's still an issue.
from dispatch.
Related Issues (20)
- Call to undefined function finfo_open() HOT 2
- Feeding `on` with names of undefined functions kills router silently
- The Road To Dispatch 5 HOT 4
- Dispatch route into sub directory HOT 2
- mod_rewrite required? HOT 4
- before() HOT 4
- Custom page titles in layout.phtml? HOT 1
- Can I set optional parameters in route? HOT 1
- Can I add a library ? And how to add it ? HOT 3
- Site in a sub-directory keeps redirecting to root HOT 2
- I found a bug in Dispatch
- How can I continue to next 'map' from current 'map'? HOT 1
- Seems url parameters break routes HOT 3
- feature to get named parameters from $_REQUEST pass to handler function. HOT 1
- PHP Fatal error: Function name must be a string in dispatch.php on line 28 HOT 2
- Is there a way to use it inside a folder? HOT 2
- Name conflict with PHP 8 data structure 'match' HOT 1
- Allow mapping of handlers against error codes (eg. 4xx, 5xx) HOT 1
- Look into allowing arguments to be passed to `next(...)` from within the middleware HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dispatch.