Connection's recv buffer should be emptied before sending new command about aredis HOT 8 CLOSED

It seems working well.
Looking forward to the next release.

from aredis.

Maybe there is another way to solve this problem. Add a state property to the Connection class, and mark a connection as busy, before sending a request and mark it as idle after handled the response. Before sending a new command, check the status.

from aredis.

That sounds reasonable, would you like to make a pr? Or i will try to fix this problem this weekend

from aredis.

@myrfy001
Do you think it should be regarded as reusable if a connection is broken(stop before or during reading response)?

For now i try to fix this issue by adding attribute to connection to indicate if it is waiting for response, if it is waiting then connection will be disconnected and never put back to available connection list again. The parse response error 'int' object has no attribute 'decode' is fixed and never raised again. (but TimeoutError raised by asyncio_timeout is still there)

But i am not sure if this kind of connection should be clean and reused again.
Looking forward to your opinion.

from aredis.

I think close the connection is the safest way. Think this situation: because of network delay, or because of large responses by bulk execution, the response of the pervious command may arrive after cleaning the buffer. So, close the connection is a safe way to avoid this. Besides, this problem is an edge case so it's seldom happens, so, there won't be a lot of reconnect action that will lower the efficiency.

from aredis.

That's good, this patch will be tested and merge to master soon.

from aredis.

@myrfy001
Patch is already merged to master and you can try it with
pip install git+https://github.com/NoneGG/aredis.git

If there are other problems please tell me~

from aredis.

@myrfy001
May i close this issue?

from aredis.