[Windows] Incorrect `mongod` binary path about mongodb-memory-server HOT 13 CLOSED

would be my first. I should try tho :)

from mongodb-memory-server.

@cmosgh thanks for debugging. 👌

Can you provide you folder structure by path C:\Users\Username\.mongodb-binaries\3.4.4 ?

Or maybe you can make PR, which will find mongod.exe in these lines:
https://github.com/nodkz/mongodb-memory-server/blob/master/src/util/MongoBinaryDownload.js#L131-L133
and
https://github.com/nodkz/mongodb-memory-server/blob/master/src/util/MongoBinaryDownload.js#L71

Moreover, will be cool if you create an internal method for obtaining correct binary path according to OS something like:

class MongoBinaryDownload {
  ...
  _getMongodPath(): string {
    if (this.platform === 'win32') {
      return __correct path___
    } else {
      return path.resolve(this.downloadDir, this.version, 'mongod');
    }
  }
}

from mongodb-memory-server.

I'm on MacOS and make a proper fix for Win quite hard for me.
Thanks for help!

from mongodb-memory-server.

MongoBinaryDownload looks for C:\Users\UserName\.mongodb-binaries\3.4.4\mongod

but the .mongodb-binaries contains only the zip archive and an empty folder folder 3.4.4

it seems that for some reason it doesn't extract the archive

from mongodb-memory-server.

So it look like that filter in decompress contains incorrect value under win32 (problems with backslash)
https://github.com/nodkz/mongodb-memory-server/blob/master/src/util/MongoBinaryDownload.js#L123

from mongodb-memory-server.

I can give you the path it receives sec

from mongodb-memory-server.

ah its pretty simple I think. since macos doesn't need .exe
filter should have added .exe and the path resolve should have the same appended

from mongodb-memory-server.

Yep needs to check this.platform === 'win32' and if is true then use path and filter for windows, otherwise keep existed values for linux and mac.

Would you try to do PR?

from mongodb-memory-server.

created a pull request but it fails to build because of prettier... haven't got that configured locally so..., maybe you can tho use the code?

from mongodb-memory-server.

Ok i'll do it.
Many thanks for PR!

from mongodb-memory-server.

Congrat with first PR 🎉

from mongodb-memory-server.

Published https://github.com/nodkz/mongodb-memory-server/releases/tag/v1.6.1

from mongodb-memory-server.

For what is worth set the binary.systemBinary option (as listed at here) to point to the correct path on the filesystem (where npm postinstall actually downloads the binary). For me this systemBinary is "X:\Project\Root\node_modules\mongodb-memory-server\node_modules\.cache\mongodb-memory-server\mongodb-binaries\x.y.z\mongod.exe" (note the double slash on Windows). Hope this helps, because even version 3.0.0 of this package wasn't working for me.

from mongodb-memory-server.