Handling of v1/auth/github/login redirect. about node-vault HOT 7 CLOSED

@kr1sp1n we should consider adding the followAllRedirects: true request option by default, if it makes sense. I didn't do any research in this specific issue, but from my (somewhat limited) knowledge of the vault API, I think it wouldn't hurt to add this.

from node-vault.

@edasque - I ran across a similar issue. The way I solved the 3xx response was to pass the request options as a field. For example:

vault.githubLogin({
    githubToken,
    requestOptions: {
        followAllRedirects: true
    }
});

from node-vault.

i have same issue

i think that is not just redirect
cuz i think node-vault is basically caller API of Vault and almost API need value of X-Vault-Token in header but this value set only time call vault.auths()

i think it is easy way that fix in handleVaultResponse function
check login url and if this request is login, set client.token
i will write example under

//that is regular expression to check url of login
if (/\/auth\/[^\/]+\/login/.test(response.request.uri.path)) {
  client.token = response.body.auth.client_token;
}

but i dont sure that is right way 😕

from node-vault.

I was struggling with this problem with relating to approleLogin().

I was catching a 'Status 307' error and I'm really glad I found this page.

I completely agree that this should be set by default.

from node-vault.

Noted for v1.0

from node-vault.

@edasque @liambowers I think PR #93 may solve your problems. It is included since v0.9.3. Please check it out and give feedback. Thanks 🙏

from node-vault.

Stale issue, closing

from node-vault.