Code Monkey home page Code Monkey logo

Comments (5)

MylesBorins avatar MylesBorins commented on September 17, 2024

/cc @jasnell @rvagg @nodejs/testing

from citgm.

mhdawson avatar mhdawson commented on September 17, 2024

Also should note that Node/V8 have a fairly flexible way to exclude tests using their status files so may be a good pattern to follow. They allow an exclude base on the platform as well as a run but allow to pass or run be allow to timeout etc.

from citgm.

jasnell avatar jasnell commented on September 17, 2024

Clarification: broken for all versions / broken on specific version ... does that means version of the module or versions of node? For instance, one could imagine that a module that is stable on v4.x could become flaky on v5.x

from citgm.

MylesBorins avatar MylesBorins commented on September 17, 2024

I am imagining that we will continue to only test the latest version of published modules. Thus Broken for all / broken on specific would refer to node version as opposed to module version.
This may get tricky as specific modules may not support LTS.

from citgm.

mhdawson avatar mhdawson commented on September 17, 2024

In terms of only testing the latest we ran into a few issues with that:

  1. If you always test the latest you don't know without investigation if the breakage is from a change in the module or a change in the runtime
  2. The latest may not support older streams like 0.12.X

We ended up doing 2 sets of runs

  1. Latest runtime, fixed set of npm module levels

  2. Last shipped runtime level, latest modules

from citgm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.