Acme air scripts runs longer than expected about benchmarking HOT 4 CLOSED

Do you mean after the END acmeair message we wait around for a while before them being killed off?

From the time stamps that are printed, it seems the acme air run (for 120 anyway) was 5mins 29 seconds.

I've checked in a change under 2db045c that keeps track of child pids (the sleep 600). This isn't a great way of doing it, it'd be good to understand why the getting children and grandchildren of this shell command in kill_bkg_processes isn't working on the benchmark machine.

That way, we could remove lots of the recording of PIDS throughout the script.

I commented out the line to get child and grandchild pids of the current shell and tested on a machine here, and my change seems to kill off the timeout now - I don't think I have access to relaunch the test on the community ci to double check there though.

from benchmarking.

The runs over the weekend seem to be running faster - 6mins 59seconds for https://ci.nodejs.org/job/benchmark-footprint-experimental/125/ vs 11minutes for 120 .

from benchmarking.

The 6-7 minutes is closer to what I expected so your change probably made the difference.

from benchmarking.

Closing as resolved

from benchmarking.