UI-Table memory leak about node-red-ui-nodes HOT 5 CLOSED

@dceejay To me too ...
@Gonzo4 Thank you for spotting that problem. I don't expect any side effects ... Will include your suggestion and do some tests with my quite heavy tables

from node-red-ui-nodes.

I have played around, destroying an already existing table will maybe solve the problem.
I have inserted the following lines to the node.js before a new table is created (between line 202 and 203):

// console.log("createTabulator",opts);
if($scope.table !== undefined)
	$scope.table.destroy();
$scope.table = new Tabulator(basediv, opts);

The memory consumption doesn't increase now, but I have no clue if there are any side effects (my javascript skills are very basic)...

from node-red-ui-nodes.

@Christian-Me - Would seem sensible to ensure removal before creating anything "new" - but... - care to comment ?

from node-red-ui-nodes.

@Christian-Me - great - will let you PR it when you are happy.

from node-red-ui-nodes.

Interesting ... I thought the GC would kick in and get rid of the unreferenced tabulator tables ... Have to learn more how the GC work. I didn't had that problem because I used commands to update / fill my tables

Fun using a profiler again, last used "Turbo Profiler" form Borland decades ago ;)

@dceejay Think I'm happy

from node-red-ui-nodes.