Code Monkey home page Code Monkey logo

Comments (11)

HappyZombies avatar HappyZombies commented on September 13, 2024

I did, though it's not an appropriate grant flow -- I can provide an example of what I did, it essentially is a middle layer that sits on top of my authorization_code grant type.

Are there any RFC guide lines for MFA for OAuth that we can maybe implement here? I really don't see anything on the official one.

from node-oauth2-server.

Uzlopak avatar Uzlopak commented on September 13, 2024

I would be happy if you could provide me the example.

I think MFA is defined in the Financial Grade API.

from node-oauth2-server.

Uzlopak avatar Uzlopak commented on September 13, 2024

@HappyZombies

I dont want to pressure you but can you tell me, when you could provide me your code, please?

Thx.

from node-oauth2-server.

HappyZombies avatar HappyZombies commented on September 13, 2024

I'll try to get something by EOD or this week, I'll throw it on the example repo. Probably be an in memory database though to speed things up

from node-oauth2-server.

jankapunkt avatar jankapunkt commented on September 13, 2024

@Uzlopak great to see you here :-D What do you both about adding this to the examples repo?

from node-oauth2-server.

HappyZombies avatar HappyZombies commented on September 13, 2024

Yup I am actually making the code in the example repo :)

from node-oauth2-server.

Uzlopak avatar Uzlopak commented on September 13, 2024

I really hope you can give me that middleware. In the meantime I start to extend oauth2-server with

Is there any interest in adding this feature to this project?

from node-oauth2-server.

jankapunkt avatar jankapunkt commented on September 13, 2024

@Uzlopak regarding the last comment I think this should be discussed in the examples repo, right @HappyZombies ?

from node-oauth2-server.

HappyZombies avatar HappyZombies commented on September 13, 2024

We can still talk here since we already got the thread going, once I put the example up we can move discussion.

@Uzlopak This isn't really a middleware, but really just extra functionality that sits on top of the authorization_code flow -- though I am sure it can be used as custom grant extension that this module provides.

I will try my best to get you an example tonight! But essentially, we have a /login route that dispatches a two factor request, if successful we store the users id in a session and the authorization_code grant will take an additional field called twoFactorCode (or whatever you want) along with the scope, scope, state, response_type, redirect_uri, and client_id.

When we call .authorize, we supply the authenticateHandler that validates the two factor code and returns the user that is trying to login (with the assistance of the session that has the user id). And so on the authorization_code flow continues.

from node-oauth2-server.

HappyZombies avatar HappyZombies commented on September 13, 2024

@Uzlopak I added the example here https://github.com/node-oauth/node-oauth2-server-examples/tree/feature.mfa-example/mfa-example Keep in mind again that this a custom implementation and doesn't follow anything in particular. Uses everything in memory.

This example is not quiet done yet, I still gotta mock/implement some small things, but the overall part of it is done :) Please let me know if you have any questions.

(Also keep in mind I kinda just threw this together, maybe with more time I can make a real working example with MySQL maybe)

from node-oauth2-server.

Uzlopak avatar Uzlopak commented on September 13, 2024

Thank you ;)

from node-oauth2-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.