Comments (13)
I put is.js
into it's own repo. @HappyZombies would you mind publishing this to NPM? Once that's done I'll update the code and create a PR. @jankapunkt feel free to clone and make any changes you see fit.
from node-oauth2-server.
Hey @jwerre this code was written by me when I added these tests. The thing is, that the RegEx that is about to be tested allows nearly the whole unicode set and I do lots of permutations in order to cover them. This is course takes lot of time.
From my pov we should not remove them but we could update the docs and describe why this test is so slow (and give some background info).
We can also add an instant remedy by describing how to use regex pattern to filter out mocha tests that are not of focus right now: https://mochajs.org/#-grep-regexp-g-regexp
What do you think?
from node-oauth2-server.
@jankapunkt Yes I remember when you wrote these test. Nice work by the way—I agree with you that they were needed. I guess I'm not clear why you wouldn't want to add is.js
as a dependance under the same organization. It's not really oauth specific, it's not likely to change, and it would shave 5.5 sec off the unit tests. It just doesn't make sense to run these tests with every deployment of node-oauth-server
when they can be run independently whenever there are changes to is.js.
from node-oauth2-server.
Ah now I get, you want to add them as internal dependency. We could do this.
from node-oauth2-server.
@jwerre @HappyZombies I would start this as a new repo under this org if you both agree
from node-oauth2-server.
@jwerre @HappyZombies I would first make some additions, like adding the namespace, updating the README, link the RFC docs etc. I'll link the PR here
from node-oauth2-server.
from node-oauth2-server.
I am sorry to be nagging on the wording, but I think the name is wrong. it is not a "is-unicode" package because some of the validators are not unicode but simple ascii. It is actually something like oauth2-formats (naming similar to something like ajv-formats).
from node-oauth2-server.
@jwerre what do you think about renaming? It's at least not published, yet.
from node-oauth2-server.
Yes! Good call @Uzlopak
from node-oauth2-server.
I will rename and then publish, so we can finally integrate it :-)
from node-oauth2-server.
Published 1.0.0: https://www.npmjs.com/package/@node-oauth/formats
Let's keep this open until we integrated it into the main package
from node-oauth2-server.
Resolved by #108
from node-oauth2-server.
Related Issues (20)
- An option to require PKCE parameters HOT 6
- Does this library support user approval dialog during authorization code grant? HOT 28
- State of this project? HOT 21
- Is implementation of `verifyScope` required? HOT 17
- generateAuthorizationCode not being awaited HOT 3
- TypeScript: Remove callback from types in 5.x HOT 4
- Move all ES5 style classes into ES6+ style class HOT 2
- getClient called with non-decoded secret/client HOT 3
- [Documentation] revokeAuthorizationCode argument should be named `code.authorizationCode`, not `code.code` HOT 4
- Client Credentials broken in 5.0.0-rc.1 HOT 12
- Insufficient integration tests HOT 3
- Contribution guidelines do not cover how to PR fixes for docs HOT 2
- wrong typing for revokeToken argument HOT 26
- PR #197 fix removed after merge HOT 3
- Typings for `validateScope` don't correctly reflect that `scope` arg can be undefined
- `authenticate` endpoint still expects `scope` as a `string` instead of `string[]` HOT 4
- PKCE Refresh token HOT 12
- Poor example code for verifyScope in docs
- `AuthenticateOptions.scope` type is declared incorrectly
- v5.1`AuthorizationOptions.scope`Breaking Change HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-oauth2-server.