EventID is always 0 about nlog.owin.logging HOT 9 CLOSED

Hello Tim,

the signature of WriteCore() is actually defined in Microsoft.Owin.Logging.ILogger. That's why there's that "eventId" parameter. We're currently not using it as you stated, but if you can tell us a requirement or use case I'll look into it.

from nlog.owin.logging.

Btw. I can't actually even find any information about the meaning of the eventId parameter (there's nothing written about it in the doc at least, and I found a couple of ILogger implementations not using it either or having funny TODO comments for the matter).

from nlog.owin.logging.

@pysco68 So, there is one way to do with

public bool WriteCore(TraceEventType eventType, int eventId, object state, Exception exception, Func<object, Exception, string> formatter)
            {
                var logLevel = _getLogLevel(eventType);
                if (state == null)
                {
                    return _nlogger.IsEnabled(logLevel);
                }
                if (!_nlogger.IsEnabled(logLevel))
                {
                    return false;
                }

                var logEvent = NLog.LogEventInfo.Create(logLevel, _nlogger.Name, exception, _nlogger.Factory.DefaultCultureInfo, formatter(state, exception));
                logEvent.Properties[EvnetIdKey] = eventId;

                _nlogger.Log(logEvent);

                return true;
            }

Why you dont using LogEventInfo?

from nlog.owin.logging.

That looks okay to me. Can you provide me some information about the meaning of the eventId?
I'd like to write that down somewhere so that it is publicly known that it's actually there...

from nlog.owin.logging.

@pysco68 EventId is identifier for logs written to Windows eventlog, providing easy monitoring etc.

from nlog.owin.logging.

fixed in #17

from nlog.owin.logging.

Will be released as 1.1. Thanks for reporting, @pysco68 thanks for fixing!

from nlog.owin.logging.

https://www.nuget.org/packages/NLog.Owin.Logging/1.1.0

from nlog.owin.logging.

@304NotModified nice, ty

from nlog.owin.logging.