This example: <div class="highlight highlight-source-js notranslate position-relat

Merged pull, updated version. <a class="user-mention notranslate" data-hovercard-type=

Example in README giving roots as only parameter does not work about gulp-serve HOT 2 CLOSED

nkt commented on August 16, 2024

Example in README giving roots as only parameter does not work

from gulp-serve.

Comments (2)

morganesque commented on August 16, 2024

Yes typeof returns object for arrays and so this test typeof config !== 'object' misses any arrays that have been passed and the next line will therefore clobber them.

Seems like you've got 4 possibilities you want to catch and you want to end up with config being an object and config.root always being an array. So (this might be a bit long winded but) how about this:

    /*
        1. If they've passed a string.   
    */     
    if (typeof config === 'string') {
      config = {root:[config]};
    }

    /*
        2. If they've passed an array.   
    */     
    if (Array.isArray(config))
    {
      config = {root: config}; 
    }

    /*
        3. If they've passed an object but not specified root.
    */     
    if (!config.root) {
      config.root = ['.'];
    }

    /*
        4. If they've passed an object but specified root as a string.
    */     
    if (typeof config.root === 'string') {
      config.root = [config.root];
    }

from gulp-serve.

nkt commented on August 16, 2024

Merged pull, updated version. @morganesque thanks!

from gulp-serve.

Related Issues (11)

Recommend Projects