Code Monkey home page Code Monkey logo

Comments (5)

nkbt avatar nkbt commented on June 29, 2024

RenderStatic is needed for the case when height is known and should not be measured.

This issue is sort of related to another one. I'm on my phone now and cannot really do anything about it. Will come back home next monday and hopefully will be able to resolve them. There is a PR already. If you can give it a try and check if issue is still there, that would be awesome!

Thanks, Nik

from react-collapse.

nkbt avatar nkbt commented on June 29, 2024

I've updated example to use the most recent versions: http://codepen.io/nkbt/pen/wGZWqG

Still a bug.

from react-collapse.

nkbt avatar nkbt commented on June 29, 2024

Updated http://codepen.io/nkbt/pen/wGZWqG with [email protected], cannot reproduce anymore the bug with child component.

There is still an issue with parent component height not being determined properly, so when it closes - it starts from the previous height.

from react-collapse.

nkbt avatar nkbt commented on June 29, 2024

I don't think there is much to do about parent one, since children effectively not changed and any new props were not passed through it, so it cannot figure out that height was changed.

though, I have an idea!

We should determine height before collapsing too.

from react-collapse.

nkbt avatar nkbt commented on June 29, 2024

Just published react-collapse@next (not latest channel yet until better tested) with full rewrite, which fixes this issue. Give it a shot if you are keen.

from react-collapse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.