Code Monkey home page Code Monkey logo

Comments (7)

daringer avatar daringer commented on July 16, 2024

cannot reproduce ;(

# to not rely on pip for removal
$ sudo rm -rf /usr/lib/python3.8/pynitrokey* /usr/bin/nitropy

# install
$ sudo pip install pynitrokey

# run
$ nitropy
*** Nitrokey tool for Nitrokey FIDO2 & Nitrokey Start
Usage: nitropy [OPTIONS] COMMAND [ARGS]...

Options:
  --help  Show this message and exit.

Commands:
  fido2    Interact with Nitrokey FIDO2 keys, see subcommands.
  ls       List Nitrokey keys (in firmware or bootloader mode)
  start    Interact with 'Nitrokey Start' keys, see subcommands.
  version  Version of pynitrokey library and tool.

dang, "works on my computer" ... will check CI, or better do a pip-based CI
ok, but CircleCI also seems to work: https://app.circleci.com/pipelines/github/Nitrokey/pynitrokey/13/workflows/b96038f1-36e9-41e9-8bc5-fb5e5a35129e , but will add a release install and run CI now to be sure

from pynitrokey.

daringer avatar daringer commented on July 16, 2024

please check:
https://app.circleci.com/pipelines/github/Nitrokey/pynitrokey/16/workflows/66511b0e-ee25-43ab-aeb6-db2950ed3834/jobs/29

any chance you forgot to use -U or something with pip?
You could also crosscheck the Makefile and tell me the difference between your install process and the one CI-ed....

from pynitrokey.

szszszsz avatar szszszsz commented on July 16, 2024

The reproduction scenario is a simple call of pip install without the -U, on a used system, with previously installed fido2 0.7.x library (so potential upgrade path from 0.3.2).

I believe the problem lies in the requirements file, where fido2 dependency lowest version is not set:

requires = [
"click >= 7.0",
"cryptography",
"ecdsa",
"fido2",
"intelhex",
"pyserial",
"pyusb",
"requests",
"pygments",
"cffi",
"cbor",

Could you update the dep version here as well by the way?

from pynitrokey.

daringer avatar daringer commented on July 16, 2024

ah ok, good finding, will be fixed in a moment

from pynitrokey.

daringer avatar daringer commented on July 16, 2024

added to CI, to not fall over it anytime later:
https://app.circleci.com/pipelines/github/Nitrokey/pynitrokey/18/workflows/f98833c7-503e-48dc-b57d-ff0bcf94c2eb/jobs/36

from pynitrokey.

szszszsz avatar szszszsz commented on July 16, 2024

While at the topic, I would go into more general way of update process check: install the previous version first, then update to latest to see, if all dependencies were set up correctly. That would require locking versions at the time at release though (either pip freeze or pipenv lock.

from pynitrokey.

szszszsz avatar szszszsz commented on July 16, 2024

Hi!
Could you make a release with that? It breaks CI unless the proper package is pinned.
Edit: https://travis-ci.org/github/Nitrokey/nitrokey-fido2-firmware/builds/729911220#L1107

from pynitrokey.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.