Code Monkey home page Code Monkey logo

Comments (2)

szszszsz avatar szszszsz commented on August 15, 2024

I do not see the purpose here. Can you elaborate on the use case?

I think further clients should not try to embed any knowledge regarding version and features relation, and instead it should be kept in the library directly communicating with the device.

from pynitrokey.

robin-nitrokey avatar robin-nitrokey commented on August 15, 2024

For nitrokey-app, I want to enforce the policy to support only the latest version, at least until the API has stabilized. In the last releases, there were many subtle changes that are difficult to map to features, e. g. PIN requirements, touch requirement, list response, etc. Similar changes in the near future could be:

We could add a feature flag for all of these and check all, but I think this is just an unnecessarily complex workaround for a version check. A version check would also represent the fact that we currently only test against a specific version. In my opinion, feature flags are more suitable for enabling and disabling larger groups of functionality like PWS support.

from pynitrokey.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.