Code Monkey home page Code Monkey logo

Comments (3)

Nition avatar Nition commented on May 18, 2024

I think you've found a legitimate bug there. Looks like the if (objects.Count == 0 && children.Length == 0) check should also be checking whether children is null. Your objects == null part should be unnecessary as objects is assigned right away and never cleared.

Try this:

if (objects.Count == 0 && (children == null || children.Length == 0)) {
	return this;
}

I've also just updated this repo with that change.

from unityoctree.

HulloImJay avatar HulloImJay commented on May 18, 2024

This seems to prevent the issue. I'm not familiar with the pull request process, so I'll just let you make the change when you are able.

Thanks! :)

from unityoctree.

Nition avatar Nition commented on May 18, 2024

All good, it's done.

from unityoctree.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.