Comments (2)
I don't think this is due to the strikethrough, it also happens w/ other input. It is always useful to look at what the crash is ;-):
Thread 1: Simultaneous accesses to 0x107200e10, but modification requires exclusive access
And the concurrent access started inLayoutComputer.EngineDelegate.sizeThatsFits
(presumably the SwiftUI layout).
It seems to be a weird interaction between WebKit (which is used for HTML parsing in NSAttributedString and seems to spin up a funky nested runloop?) and SwiftUI.
Actually it is probably "more complex HTML" which is piped through WebKit (maybe a "
or <!--
also triggers this. I tried to replicate it in a test case, which doesn't raise. Because the SwiftUI is missing.
The case we are currently seeing is a message which contains "<name> changed"
. CommonMarkAttributedString tries to pipe this through NSAttributedString(...html) which produces the issue.
Which I suppose brings us full circle why we even parse the stuff as Markdown ;-) This <name>
is verbatim content.
from nio.
Fixed with #272.
from nio.
Related Issues (20)
- Leaving a room should exist as a context menu action on the room HOT 3
- Disable iOS specific features in Catalyst build
- Copy message action
- Messages black out when highlighted.
- Reaction grouping
- Settings and New Chat buttons are missing accessibility labels in the Mio version HOT 3
- Message parsing: Replace Markdown with HTML HOT 7
- Message Composition: Parse Markdown and send HTML HOT 8
- Doesn't support delegation at login HOT 2
- Message stuck at the bottom when messages fail to send HOT 3
- when are you going out of beta or testflight ? HOT 1
- Session verification HOT 2
- Allow connecting to homeservers that do not have https HOT 2
- New color for links in darkmode HOT 1
- TestFlight beta not accepting new testers
- Probable memory leak
- macOS support (and multiplatform in general) HOT 6
- Provide IPA archive for sideloading HOT 1
- Please open the Beta TestFlight to more users HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
Strikethrough HTMLleads to crashfrom nio.