Some thoughts about erlang.mk HOT 9 CLOSED

• Why? If there's a warning, then something is wrong.
• Send a patch if you know how to do it better.
• You can override the default target, as far as I can tell that's all that's needed for 99% of the cases.

from erlang.mk.

1. Because it affects building dependencies too. You can't respond for others. If dependency code has warnings, your target won't build.
2. Yes, looking at that.
3. Agree.

from erlang.mk.

If the dependency has warnings, you should first be concerned about using it, and then consider patching it if you really want to use it. Otherwise if you're really really sure you want to use it as-is you can always change the erlc flags in your makefile. Don't think we need to do anything there.

from erlang.mk.

1. $(PROJECT) should be set (with ?=, to allow explicit overriding) to basename of the current dir make observes, to ease implicit injection of erlang.mk for deps that lack it.

from erlang.mk.

01:40:54         nox | essen: if you do a rule such as test_%: test/%_SUITE.erl, you can make a per-suite test target                                                        
12:40:10         nox | essen: if you want cool Make ideas                                                                                                                    
12:40:20         nox | take a look at ghc's targets                                                                                                                          
12:40:38         nox | they have a non-recursive make infrastructure with a lot of fancy targets like what I suggested                                                       
(DONE) 12:41:18         nox | also essen, in the ct_run call you do "-pa ebin $(DEPS_DIR)/*/ebin"                                                                                   
(DONE) 12:41:50         nox | if you give an absolute directory for ebin, ct_run will not say Converting "ebin" to "blablabla/ebin" and re-inserting with add_patha/1 on every run  

from erlang.mk.

Someone also suggested a way to override targets like $(erlang.mk)compile: ...

from erlang.mk.

Hey,
• Considering L103, nox has a good lead IMHO
• Another thought: this makes for a more modular base Makefile IMHO

PROJECT = my_app

all: erlang.mk

erlang.mk:
         git clone https://github.com/extend/erlang.mk.git erlang.mk.git
         mv erlang.mk.git/erlang.mk $@
         rm -rf erlang.mk.git

include erlang.mk

• Last thought: PROJECT (the variable holding the project's name) should maybe be APP instead. Every Erlang/OTP project is either an application or a application library, hence APP.

from erlang.mk.

Set vsn attribute of all modules: https://twitter.com/nokusu/status/398849986701828096

from erlang.mk.

I believe all of this is either done or covered by other issues. If I missed something, please open an individual ticket per issue. Thanks!

from erlang.mk.