Receiving intermittent frame size error for `RST_STREAM` frames. about cowlib HOT 5 CLOSED

No need for another clause, it'll end up unmatched until the very last clause which asks for more data.

from cowlib.

The clause you linked to in cow_http2 is missing a when Len =/= 4 , it's a little too large in what it matches.

from cowlib.

So, for the use case, I described above. I should ensure that gen_tcp doesn't break the RST_STREAM frames in case the OS Buffers are full. Right? Aka: I might have to open an issue for the Mint client

If I'm not mistaken, the previous clause matches for clauses where Len >= 4.

parse(<< 4:24, 3:8, _:9, StreamID:31, ErrorCode:32, Rest/bits >>) ->
	{ok, {rst_stream, StreamID, parse_error_code(ErrorCode)}, Rest};

If it's > 4 it will parse the error and return the rest of the data. If it's == 4 the Rest will be <<>> - That being said, I don't think you need a when guard here

from cowlib.

Nothing to change in clients. The previous clause doesn't match because Len is the first 24 bits and it's 4 in that clause. We need to make the catch-all a little less catch-all to not match incomplete packets with valid lengths.

from cowlib.

Ahhh Gotcha!

So, wrapping up:

• Add another clause to match the incomplete packet (with valid length, type and stream_id (maybe))
  • ask for more data
• Last clause will be - as you said - match for Length =/= 4
  • This clause will return the Frame Size Error

from cowlib.