Code Monkey home page Code Monkey logo

Comments (7)

petruavram avatar petruavram commented on July 20, 2024

This also appears for PHP in my testing:

  1. write doc block start in PHP \**
  2. hit Space or Enter

Atom Version: 1.0.0
System: Mac OS X 10.10.3
Thrown From: docblockr package, v0.7.2

Stack Trace

Uncaught TypeError: Cannot read property '1' of null

At /Users/pavram/.atom/packages/docblockr/lib/languages/php.js:67

TypeError: Cannot read property '1' of null
  at DocsParser.PhpParser.get_arg_name (/Users/pavram/.atom/packages/docblockr/lib/languages/php.js:67:19)
  at DocsParser.parse_args (/Users/pavram/.atom/packages/docblockr/lib/docsparser.js:265:48)
  at DocsParser.format_function (/Users/pavram/.atom/packages/docblockr/lib/docsparser.js:130:32)
  at DocsParser.parse (/Users/pavram/.atom/packages/docblockr/lib/docsparser.js:44:37)
  at DocBlockrAtom.module.exports.DocBlockrAtom.parse_command (/Users/pavram/.atom/packages/docblockr/lib/docblockr-worker.js:279:29)
  at atom-workspace.<anonymous> (/Users/pavram/.atom/packages/docblockr/lib/docblockr-worker.js:41:16)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:241:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:520:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:355:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:180:20)

Commands

  3x -0:18.8.0 core:move-up (atom-text-editor.editor.is-focused)
  4x -0:18.1.0 core:move-down (atom-text-editor.editor.is-focused)
  3x -0:16.9.0 core:move-up (atom-text-editor.editor.is-focused)
  3x -0:16 core:move-down (atom-text-editor.editor.is-focused)
     -0:06.5.0 docblockr:parse-enter (atom-text-editor.editor.is-focused)
  3x -0:05.9.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:01.4.0 docblockr:parse-tab (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "themes": [
      "one-light-ui",
      "one-light-syntax"
    ]
  }
}

Installed Packages

# User
autocomplete-modules, v1.0.0
autocomplete-php, v0.3.6
autocomplete-polymer, v0.2.3
docblockr, v0.7.2
language-javascript-jsx, v0.3.6

# Dev
No dev packages

from docblockr.

petruavram avatar petruavram commented on July 20, 2024

What's worse and I forgot to mention is that going around this problem is not easy because you can't write the documentation manually as it'll keep throwing this error. I can provide a small code sample if it's necessary.

from docblockr.

Chais avatar Chais commented on July 20, 2024

Still happens for C++.
Steps to reproduce:

  1. Start a documentation block with '/*!' (valid for doxygen)
  2. Press Enter

from docblockr.

stretchtiberius avatar stretchtiberius commented on July 20, 2024

I have noticed it happens in C++ when commenting a function prototype with a 2D array parameter.

Steps to reproduce:

  1. Create function prototype with a 2D array parameter. For example, void x (int y [][4]);
  2. Start a document block right above the prototype with /**
  3. Press Enter

from docblockr.

vjeranc avatar vjeranc commented on July 20, 2024

This also happens in C++ if definition is missing a parameter name.

return_type FuncName(Argument1Type &, Argument2Type &arg2);

from docblockr.

octoquad avatar octoquad commented on July 20, 2024

Got this a earlier today in PHP as well.

Step 1: Create a method in a class:

<?php
class Test {
    public static function test($name, $array = ['true', '1']) { }
}

Step 2: Insert /** then Enter

Docblockr seems to parse the argument list correctly if you change the second method argument to:

<?php
class Test {
    public static function test($name, $array = array('true', '1')) { }
}

Additionally Atom doesn't seem to color the second argument or anything after it. I'm not sure if that could be contributing to the problem:
Atom Preview

Let me know if you need any more information.

Atom Version: 1.3.0
System: Ubuntu 15.10
Thrown From: docblockr package, v0.7.3

Stack Trace

Uncaught TypeError: Cannot read property '1' of null

At /home/bruce/dev/configs/atom/packages/docblockr/lib/languages/php.js:67

TypeError: Cannot read property '1' of null
    at DocsParser.PhpParser.get_arg_name (/home/bruce/dev/configs/atom/packages/docblockr/lib/languages/php.js:67:19)
    at DocsParser.parse_args (/home/bruce/dev/configs/atom/packages/docblockr/lib/docsparser.js:265:48)
    at DocsParser.format_function (/home/bruce/dev/configs/atom/packages/docblockr/lib/docsparser.js:130:32)
    at DocsParser.parse (/home/bruce/dev/configs/atom/packages/docblockr/lib/docsparser.js:44:37)
    at DocBlockrAtom.module.exports.DocBlockrAtom.parse_command (/home/bruce/dev/configs/atom/packages/docblockr/lib/docblockr-worker.js:279:29)
    at atom-workspace.<anonymous> (/home/bruce/dev/configs/atom/packages/docblockr/lib/docblockr-worker.js:75:16)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/opt/atom/resources/app.asar/src/command-registry.js:260:29)
    at /opt/atom/resources/app.asar/src/command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/opt/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:536:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/opt/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:359:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeydown (/opt/atom/resources/app.asar/src/window-event-handler.js:99:36)
    at HTMLDocument.<anonymous> (/opt/atom/resources/app.asar/src/window-event-handler.js:3:61)

Commands

     -1:45.7.0 docblockr:parse-enter (atom-text-editor.editor.is-focused)
     -1:45.7.0 editor:newline (atom-text-editor.editor.is-focused)
     -1:45.4.0 core:save (atom-text-editor.editor.is-focused)
     -1:34.5.0 markdown-writer:indent-list-line (atom-text-editor.editor.is-focused)
     -1:34.5.0 snippets:next-tab-stop (atom-text-editor.editor.is-focused)
     -1:34.5.0 snippets:expand (atom-text-editor.editor.is-focused)
     -1:34.5.0 docblockr:parse-tab (atom-text-editor.editor.is-focused)
     -1:34.5.0 editor:indent (atom-text-editor.editor.is-focused)
     -1:34.1.0 markdown-writer:insert-new-line (atom-text-editor.editor.is-focused)
     -1:34.1.0 docblockr:parse-enter (atom-text-editor.editor.is-focused)
     -1:34.1.0 editor:newline (atom-text-editor.editor.is-focused)
     -1:33 markdown-writer:insert-new-line (atom-text-editor.editor.is-focused)
     -1:33 docblockr:parse-enter (atom-text-editor.editor.is-focused)
  3x -0:02.7.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:01.0 markdown-writer:insert-new-line (atom-text-editor.editor.is-focused)
     -0:01.0 docblockr:parse-enter (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "projectHome": "/home/bruce/dev/",
    "audioBeep": false,
    "autoHideMenuBar": true
  }
}

Installed Packages

# User
atom-alignment, v0.12.1
autocomplete-php, v0.3.7
color-picker, v2.0.14
docblockr, v0.7.3
editorconfig, v1.2.2
file-icons, v1.6.13
highlight-selected, v0.11.1
language-apache, v1.4.0
language-asciidoc, v0.12.0
language-blade, v0.16.0
language-html, v0.44.0
language-restructuredtext, v0.11.0
language-textile, v0.2.0
linter, v1.11.3
linter-csslint, v1.2.0
linter-gcc, v0.5.11
linter-jshint, v1.2.2
linter-phpcs, v1.3.0
linter-pylint, v1.2.0
linter-scss-lint, v2.5.0
linter-shellcheck, v1.1.0
linter-tidy, v1.0.1
markdown-writer, v2.2.0
meteor-api, v2.20.0
minimap, v4.19.0
pigments, v0.19.6
project-manager, v2.7.1
rst-preview-pandoc, v0.1.12
run-in-terminal, v0.5.0
symbol-gen, v1.0.0
tabs-to-spaces, v1.0.1
toggle-quotes, v1.0.0

# Dev
No dev packages

from docblockr.

stretchtiberius avatar stretchtiberius commented on July 20, 2024

I noticed that issue is still listed as closed in spite of all the reports that it is not resolved. Are there plans for this issue to be addressed?

from docblockr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.