Comments (4)
Hi! Thanks for the time to bring this issue.
I did not noticed this since my decks usually don't run tokens. I assumed the YGOPRODeck endpoint with no filters would return all cards, but it seems its not the case.
I'm seeing if there is a simple way to add it to do this but it seems I will have to hardcode all card types for it to get tokens.
If this is necessary I will probably add a /tokens
command and add it to /all
, since tokens are technically not cards.
from edopro-hd-downloader.
Ok, so I checked a bit and seems that /allcards
downloads tokens without errors.
I downloaded v2.1 and run '/allcards' on an empty pics
folder and trackers. All 12723 cards returned by the YGOPRODeck API were downloaded, including the 107 tokens.
So it is not an issue with all tokens and, maybe, is an issue with your current machine or configuration.
If the game happens to have more than 107 tokens and they are not returned by the API I don't see a reason for they to be downloaded if manually put into a decklist.
So,
- make sure it's not your anti-virus randomly blocking cards, folder permission configurations or something similar;
- which token(s) you had trouble downloading?
from edopro-hd-downloader.
I had no card pics at all and ran the "/all" command, which includes the "/allcards" command, but when I played some random duels vs AI, I realized that none of the tokens were downloaded. Explicitely the "Primal Being Token", the "Adventurer Token" and 2 different versions of the "Mecha Phantom Beast Token". All other cards were downloaded successfully, so I doubt that an anti-virus software blocks the specific download of tokens. Anyhow a "/tokens" command would be very useful so you could just download your deck and the tokens instead of spending alot of time and bandwidth on downloading all cards at once.
I actually branched the project and made a draft. I will create a pull request for that.
from edopro-hd-downloader.
Okay I think I might have located a possible source of error. When looking through the ygoprodeck Card Database filtering for tokens, there is exactly 1 Mecha Phantom Beast Token, with the ID of 904186. This corresponds to none of the following constants in the EDOPro constant.lua file, nor to any of the explicitely called ids in the scripts of Mecha Phantom Beast cards.
31533705 | TOKEN_MECHA_PHANTOM_BEAST
22110648 | TOKEN_MECHA_PHANTOM_BEAST_DRACOSSACK
20368764 | TOKEN_MECHA_PHANTOM_BEAST_HARRLIARD
67922703 | TOKEN_MECHA_PHANTOM_BEAST_TETHERWOLF
So it seems like EDOPro just doesn't use official tokens for some of the cards which makes the exact assignment of ids to token artworks very difficult.
from edopro-hd-downloader.
Related Issues (8)
- Unofficial Card Texts HOT 1
- Include GOAT (Pre-Errata) card HOT 1
- program is very very slow at downloading cards when previously it was not so slow HOT 6
- Extremely slow download speed HOT 6
- HTTP Error 403 HOT 4
- Error when trying to download HOT 4
- Would this program overwrite existing images if their ID is not specified in the tracker? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edopro-hd-downloader.