Feature Request: GLEW_VERSION from glew.h about glew HOT 14 CLOSED

Interesting.

I can see that auto/Makefile is supposed to be substituting these in glew.c...

    perl -e "s/GLEW_VERSION_STRING/$(GLEW_VERSION)/g" -pi $@
    perl -e "s/GLEW_VERSION_MAJOR_STRING/$(GLEW_MAJOR)/g" -pi $@
    perl -e "s/GLEW_VERSION_MINOR_STRING/$(GLEW_MINOR)/g" -pi $@
    perl -e "s/GLEW_VERSION_MICRO_STRING/$(GLEW_MICRO)/g" -pi $@

from glew.

Oh, looks like these are constant, for querying glewGetString

const GLubyte * GLEWAPIENTRY glewGetString (GLenum name)
{
  static const GLubyte* _glewString[] =
  {
    (const GLubyte*)NULL,
    (const GLubyte*)"1.11.0",
    (const GLubyte*)"1",
    (const GLubyte*)"11",
    (const GLubyte*)"0"
  };
  const size_t max_string = sizeof(_glewString)/sizeof(*_glewString) - 1;
  return _glewString[(size_t)name > max_string ? 0 : (size_t)name];
}

Not a bug?

from glew.

Hm, but it's still useful to have version constants in header file so you can determine glew version while configuring. Not in runtime.

from glew.

Something along the lines of pkg-config?

pkg-config --modversion  glew

from glew.

Maybe... But I was talking about cmake configure and I'm not sure than pkg-config approach works for OS X not talking abount Windows. So constants-in-header approach seems more cross-platform friendly for me. Actually many libraries (SDL2, glfw for example) have both configure/compile time version defines in headers and runtime function to get version because runtime version can differ from compile version.

from glew.

Renaming this issue to: Feature Request: GLEW_VERSION from glew.h

from glew.

So... Any chance this feature request gets implemented any soon?

from glew.

Yeah, I'm not really opposed to it.
But I don't want to hold up a GLEW release at the moment...

from glew.

I happened across a similar feature in libpng this week.
http://sourceforge.net/p/libpng/code/ci/master/tree/png.h

Is this a good model to use?

#define PNG_LIBPNG_VER_MAJOR   1
#define PNG_LIBPNG_VER_MINOR   6
#define PNG_LIBPNG_VER_RELEASE 16

from glew.

yeah something like that

from glew.

I've created pull request that fixes that issue in a backwards compatible way #33

from glew.

Thanks for the pull request. I put some comments over there too, do you mind revisiting this?

from glew.

I put a change into github master branch. Does it seem sufficient?

from glew.

At first look it's fine. Thanks.

from glew.