Comments (9)
I believe it's the same case as #113 (comment).
And your type checker should warn you that your input type list[int]
is unsupported.
from crc.
I am using the default setting of pylance in vscode, and here is my screenshot:
from crc.
I believe it's the same case as #113 (comment). And your type checker should warn you that your input type
list[int]
is unsupported.
Oh, I thought iterable of bytes
in the doc is similar to iterable of ints
...
Thanks for the explanation, is it possible to print a warning when user gives a list[int]? I actually debugged for a long time to notice crc
module has such behavior.
from crc.
AFAIK, vscode doesn't show any warning when I pass a list[int] to checksum
method.
from crc.
Just double checked it quickly: it does, both mypy and Pylance provide this error for you. Please check your type checker configuration.
Also, I think it should be
-calc = Calculator(Crc32.CRC32)
+calc = Calculator(Crc32.CRC32.value)
from crc.
Well, my concerns are solved, you can close this issue if you wish, Thanks!
from crc.
I am using the default setting of pylance in vscode, and here is my screenshot:
Looks like you have some broader issues with Pylance in your VS Code setup then. Check basic things like: correct Python interpreter set up in VS Code? Type something obviously wrong; does it warn you at all? E.g. print(1234 + "foo")
If I have an invalid Python interpreter selected it will be silent as in your screenshot.
from crc.
Guess you are right, pylance doesn't show any error even when the python interpreter is detected. Anyway, thanks for the info.
from crc.
@gertvdijk thanks for taking care of this. @noonchen-ni as discussed the issue will be closed.
For further details see also : #113 (comment)
from crc.
Related Issues (20)
- mypy error: Skipping analyzing "crc": [...] missing library stubs or py.typed marker HOT 8
- Invalid checksum for HDLC Frame HOT 2
- π Invalid checksum is calculated when using `Calculator` instead of `Register` classes HOT 10
- Crc8.SAEJ1850 has wrong `init_value` and `final_xor_value` HOT 2
- π Readme update HOT 2
- πPredefined `Crc16.CCITT` is confusing HOT 4
- π§ Refactor CRC-16 Configuration Naming and Expand Variants HOT 4
- π Return of digest() is not stable HOT 2
- π My project on github uses crc. When I ran my tests I got an error relating to CCITT HOT 1
- Add support for arbitrary input and output bit widths HOT 7
- Automate pypi deployment with GitHub action(s) HOT 1
- Automate code coverage reporting with GitHub Actions
- lookup table generation output is wrong HOT 1
- file input handling could be better HOT 1
- Create a pypi release containing the latest changes HOT 1
- Implement Reverse Input/Output Lookup Table when running table_based HOT 7
- Add missing __version__ attribute HOT 2
- "poly" should be "polynomial" in example HOT 1
- Add 16bit MODBUS config HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crc.