Inconsistent CRC result for different input type about crc HOT 9 CLOSED

I believe it's the same case as #113 (comment).
And your type checker should warn you that your input type list[int] is unsupported.

from crc.

I am using the default setting of pylance in vscode, and here is my screenshot:

from crc.

I believe it's the same case as #113 (comment). And your type checker should warn you that your input type list[int] is unsupported.

Oh, I thought iterable of bytes in the doc is similar to iterable of ints...

Thanks for the explanation, is it possible to print a warning when user gives a list[int]? I actually debugged for a long time to notice crc module has such behavior.

from crc.

AFAIK, vscode doesn't show any warning when I pass a list[int] to checksum method.

from crc.

Just double checked it quickly: it does, both mypy and Pylance provide this error for you. Please check your type checker configuration.

Also, I think it should be

-calc = Calculator(Crc32.CRC32)
+calc = Calculator(Crc32.CRC32.value)

from crc.

Well, my concerns are solved, you can close this issue if you wish, Thanks!

from crc.

I am using the default setting of pylance in vscode, and here is my screenshot:

Looks like you have some broader issues with Pylance in your VS Code setup then. Check basic things like: correct Python interpreter set up in VS Code? Type something obviously wrong; does it warn you at all? E.g. print(1234 + "foo")

If I have an invalid Python interpreter selected it will be silent as in your screenshot.

from crc.

Guess you are right, pylance doesn't show any error even when the python interpreter is detected. Anyway, thanks for the info.

from crc.

@gertvdijk thanks for taking care of this. @noonchen-ni as discussed the issue will be closed.
For further details see also : #113 (comment)

from crc.