Code Monkey home page Code Monkey logo

Comments (4)

nico3333fr avatar nico3333fr commented on June 11, 2024

Hi,

yes it is possible, in fact, I made the choice to have "cool" selectors like $all_tab_links = $parent.find( ".js-tablist__link" ) which are selecting all childs (including sub-childs). It allows to be cool if you need extra-divs in the tab structure (and nested tabs are not the most frequent case I have).

However if you want to have nested tabs, it can create problems, like the one you encountered. :-\

I've made a quick test with stricter selectors like > .js-tablist > .js-tablist__item:first-child > .js-tablist__link (see attached file), it seems to be ok with nested tabs for me, could you test and confirm it is working for you ?

jquery-accessible-tabs.zip

If it is okay for you, I will probably upload this file and explain the workaround. Anyway, at the next refactoring, I will probably set it up as an option.

Could you confirm it works now?

from jquery-accessible-tabs-aria.

dameert avatar dameert commented on June 11, 2024

We tested this, it works very nicely! Thank you for the fast fix.

from jquery-accessible-tabs-aria.

nico3333fr avatar nico3333fr commented on June 11, 2024

Thanks for testing it too (it was quickly-done) :)

from jquery-accessible-tabs-aria.

nico3333fr avatar nico3333fr commented on June 11, 2024

Hi,

updates are committed, see https://github.com/nico3333fr/jquery-accessible-tabs-aria/blob/master/jquery-accessible-nested-tabs.js ;)

Thanks a lot.

from jquery-accessible-tabs-aria.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.