Code Monkey home page Code Monkey logo

Comments (5)

nickmerwin avatar nickmerwin commented on May 19, 2024

Hi @arboleya unfortunately we're not able to merge coverage data across CI's yet (unless the job ids are the same). I can see how this could work -- cross-referencing the commit SHA as opposed to the build number from the CI. Supporting arbitrary number of CI's per build has quite a few UI implications, but is definitely doable.

I'm not sure how this will fit into our dev queue, but I'll keep you posted!

PS perhaps you could hack this by short circuiting the CI_BUILD_NUMBER and CI_JOB_ID to be the current git SHA in the build ENV, but then you'd need a way to handle multiple webhooks. If you know one of the CI's always takes the longest, you may be able to get away with having that one send the hook.

from node-coveralls.

arboleya avatar arboleya commented on May 19, 2024

Oh I see, sad thing. But there's support for multiples builds from the same CI?

Because if yes, it'd be a matter of using the commit SHA as identifier instead of a build number or whatever you are using now. Am I being too simplistic?

from node-coveralls.

nickmerwin avatar nickmerwin commented on May 19, 2024

Yes, that's possible, but the other issues would be:

  • linking to the separate CI's from the build/job views
  • knowing when all have completed in order to send notifications / update PR status checks on GH

from node-coveralls.

arboleya avatar arboleya commented on May 19, 2024

Linking to separate CI's shouldn't be hard, it's one pattern per service.

I wouldn't mind about know when it's finished, too complicated. Instead, I'd be always merging payloads that are sent, so you sent just one, you got coverage for one. If another one comes in, merge data, display a new CI button, e display the percentage of it all.

Well, just ideas.. as it is absolutely out of my control :)

I'm thinking about doing a middleware where all my tests posts its coverage to, then I get all merged and submit all at once as a single report. Not ideal, will take some time, but it's doable.

It's a feature I didn't find anywhere, not in coveralls, not in codeclimate etc.

Could be a differential too.

from node-coveralls.

terinjokes avatar terinjokes commented on May 19, 2024

@nickmerwin I'd also be interested in being able to support different CI vendors, since i also use travis + appveyor.

from node-coveralls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.