Suggestion: sort invetory pokemon about pokemongoapi-php HOT 8 CLOSED

This should sort by pokemon id and CP.

$pokemons = $pokebank->getPokemons();

$pokemons = $pokemons->sort(function ($a, $b) {
            if ($a->getPokemonId() != $b->getPokemonId()) {
                return ($a->getPokemonId() < $b->getPokemonId()) ? -1 : 1;
            }
            return $a->getCp() - $b->getCp();
        });

from pokemongoapi-php.

Alright, the PokeBank now returns a PokemonCollection on which you can sort by name, level, cp, pokedex index and IV ratio.

Have a look.

from pokemongoapi-php.

This is working just fine, tested with the Pokemon Collection

from pokemongoapi-php.

Resolved.

from pokemongoapi-php.

As in game, I tried to sort PokemonCollection by Pokedex Index.
In game, when I sort by pokedex index or by name, Pokemons with the same name or the same pok# are then sorted automatically by CP (desc).

Here, as we can see in the image attached, we have 3 Weedle with CP unsorted.

Is there a way to make that once we sort by name or pokedex #, it automatically sort by CP desc too?

Like in database queries: "sort by name asc, cp desc"

from pokemongoapi-php.

Try the following snippet

$pokemons = $pokemons->sort(function (Pokemon $a, Pokemon $b) {
            if ($a->getPokemonId() != $b->getPokemonId()) {
                return ($a->getPokemonId() < $b->getPokemonId()) ? -1 : 1;
            }
            return $a->getCp() - $b->getCp();
        });

from pokemongoapi-php.

I can't make it works. I'm sure doing something wrong.

First I get the pokemons, sorted by PokedexIndex

$pokemons = $pokeBank->getPokemons()->sortByPokedexIndex();

Then I write your snippet

$pokemons = $pokemons->sort(function (Pokemon $a, Pokemon $b) {
            if ($a->getPokemonId() != $b->getPokemonId()) {
                return ($a->getPokemonId() < $b->getPokemonId()) ? -1 : 1;
            }
            return $a->getCp() - $b->getCp();
        });

But it gives me errors

Uncaught TypeError: Argument 1 passed to {closure}() must be an instance of Pokemon, instance of NicklasW\PkmGoApi\Api\Pokemon\Pokemon given

from pokemongoapi-php.

ok, now it works perfectly.

I just changed the return at the end

$pokemons = $pokemons->sort(function ($a, $b) {
            if ($a->getPokemonId() != $b->getPokemonId()) {
                return ($a->getPokemonId() < $b->getPokemonId()) ? -1 : 1;
            }
            return $b->getCp() - $a->getCp();
        });

So, I get the highest CP first

from pokemongoapi-php.