Code Monkey home page Code Monkey logo

Comments (9)

DragonStar01 avatar DragonStar01 commented on August 11, 2024 1

see #6

from pokemongoapi-php.

NicklasWallgren avatar NicklasWallgren commented on August 11, 2024 1

@arianrashidi: You are right, I will reconsider this.

from pokemongoapi-php.

NicklasWallgren avatar NicklasWallgren commented on August 11, 2024 1

The environment file is now optional, and is referenced by file path.

from pokemongoapi-php.

Ni42 avatar Ni42 commented on August 11, 2024 1

I wonder if it would be easier to just pass an array of options to the constructor instead of a file path?

Then everyone could decide for himself if he wants a dotenv file, real environment variables, store the config in a php array or anything else when bootstrapping the Kernel. I mean, you are already passing three config options to it already anyways.

from pokemongoapi-php.

arianrashidi avatar arianrashidi commented on August 11, 2024

There is also a problem with the facades if you use it as an composer package. You could consider prefixing them with a namespace.

from pokemongoapi-php.

NicklasWallgren avatar NicklasWallgren commented on August 11, 2024

@ArianR Due to the class alias?

from pokemongoapi-php.

arianrashidi avatar arianrashidi commented on August 11, 2024

@NicklasWallgren Yes, for example "src/Services/RequestService.php:38".

from pokemongoapi-php.

NicklasWallgren avatar NicklasWallgren commented on August 11, 2024

@Ni42 Good idea, I will consider this for a upcoming release.

from pokemongoapi-php.

NicklasWallgren avatar NicklasWallgren commented on August 11, 2024

I'm closing this issue. I will fix the Facades in upcoming commit.

from pokemongoapi-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.