Comments (6)
Can you show me an example of what the output looks like on your end and what you would expect to see instead?
from ansible-docker.
Got:
# Ansible managed
[Service]
Environment=HTTP_PROXY=http://proxy.corp:3128" "HTTPS_PROXY=http://proxy.corp:3128" "NO_PROXY=127.0.0.1/8
Expected (and got this by reversing the change):
# Ansible managed
[Service]
Environment="HTTP_PROXY=http://proxy.corp:3128" "HTTPS_PROXY=http://proxy.corp:3128" "NO_PROXY=127.0.0.1/8"
from ansible-docker.
variable:
docker__daemon_environment:
- "HTTP_PROXY=http://proxy.corp:3128"
- "HTTPS_PROXY=http://proxy.corp:3128"
- "NO_PROXY=127.0.0.1/8"
from ansible-docker.
I'm able to confirm that here and funny enough systemd is ok with quote mismatches so it didn't prevent the Docker daemon from starting up.
I just re-worked the template to generate multiple environment variables to be more clear by outputting each one on their own line and to avoid any quote shenanigans.
Can you double confirm it works for you by changing templates/etc/systemd/docker.service.d/environment.conf.j2
to:
# {{ ansible_managed }}
[Service]
{% for env in docker__daemon_environment %}
Environment="{{ env }}"
{% endfor %}
It should produce this output:
# Ansible managed
[Service]
Environment="HTTP_PROXY=http://proxy.a.com:80"
Environment="HTTPS_PROXY=https://proxy.a.com:443"
With an input of:
docker__daemon_environment:
- "HTTP_PROXY=http://proxy.a.com:80"
- "HTTPS_PROXY=https://proxy.a.com:443"
from ansible-docker.
It works!
Actually the single line appeared to work as well, but this is the correct way anyways.
from ansible-docker.
Cool.
Yeah if the quotes were lined up it should have worked on 1 line in the end.
I just pushed v1.9.1 to the Galaxy with this fix and here's the commit: beaaccb
from ansible-docker.
Related Issues (20)
- Support for docker.io package (in addition to ce and ee) HOT 4
- Failed : Install Docker's dependencies HOT 9
- Package dependency error for Docker installation on clean Ubuntu 18.04 HOT 11
- Ubuntu 20.04 ImportError: No module named pkg_resources HOT 10
- Avoid docker login issue with X11 HOT 11
- Expected behavior for DockerHub private repositories login options? HOT 19
- Failed to import the required Python library HOT 10
- Update apt cache before installing packages HOT 1
- Add way to add additional packages to install HOT 3
- Versioning pinning not working HOT 5
- Install Python packages: Could not get output from /usr/local/bin/virtualenv --help HOT 16
- Hi; Please consider suppressing credentials output in: Manage Docker registry login credentials HOT 8
- Upgrade edge case HOT 9
- I'm thinking about no longer setting up a virtualenv, pip installing docker / docker compose and switching the docker_login module to a shell script HOT 2
- docker not installed into /usr/local/bin HOT 4
- Unable to find pip in the virtualenv HOT 8
- Error in new v2.2.0 version when using ansible 2.9.14 HOT 3
- Docker Compose V1 causes the Install Python packages step to crash HOT 3
- Error with pip on basic usage HOT 2
- Task exception at: Install Python packages HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ansible-docker.