Code Monkey home page Code Monkey logo

Comments (7)

nickjj avatar nickjj commented on June 12, 2024

What happens if you upgrade to v1.2.0?

The readme instructions are based off v1.2.0 and in between 1.1.0 and 1.2.0 I changed all of the variable defaults to start with docker__ instead of docker_.

In your case, if you plan to stick with 1.1.0 change your vars to docker_daemon_options and docker_registries, otherwise upgrade to 1.2.0 and things should work as is.

from ansible-docker.

atkinsj avatar atkinsj commented on June 12, 2024

I don't see 1.3.0 published in to Galaxy, only 1.2.0. Upgrading to 1.2.0 and switching from double underscore to single underscore resolves it though, thank you!

from ansible-docker.

nickjj avatar nickjj commented on June 12, 2024

Yep I had to edit my comment, I thought 1.3.0 was the latest public release, but as you discovered, it's 1.2.0.

Upgrading to 1.2.0 and switching from double underscore to single underscore resolves it though, thank you!

This shouldn't work by the way. If you're using 1.2.0, you should be using double underscores.

from ansible-docker.

atkinsj avatar atkinsj commented on June 12, 2024

Strange. Double underscores don't work with 1.2.0 but single does for me.

ansible-galaxy list 
- nickjj.docker, v1.2.0

group_vars/all: docker_daemon_options: "\"dns\": [\"{{ dns_servers | join('\", \"')}}\"]"

TASK [nickjj.docker : Configure Docker daemon options] ******************************************************************************************************************************************
changed: [redacted]

from ansible-docker.

nickjj avatar nickjj commented on June 12, 2024

Ok now I see what happened. I could have sworn I pushed 1.3.0, but it looks like I forgot to push the tag 5 days ago when I released 1.3.0.

1.3.0 is now available on the Galaxy and you should be using double underscores with that.

Also, the readme file is lined up with 1.3.0.

from ansible-docker.

atkinsj avatar atkinsj commented on June 12, 2024

That sums it up, thank you!

from ansible-docker.

nickjj avatar nickjj commented on June 12, 2024

No problem, thanks for reporting the issue. Time to put some automated things in place so mistakes like this don't happen in the future!

from ansible-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.