Code Monkey home page Code Monkey logo

Comments (5)

nickjj avatar nickjj commented on June 12, 2024 1

Configuration is now done in /etc/docker/daemon.json as of v1.1.0 of this role.

from ansible-docker.

nickjj avatar nickjj commented on June 12, 2024

Hi,

In that reference snippet they included the phrase "start the process manually", which makes me think they wouldn't be using systemd when they started it, and in turn it would be a problem because if the service stopped and came back on through systemd then the flag wouldn't take effect.

But in our case, we write the options out to the systemd unit file so they always take effect. That's all handled here https://github.com/nickjj/ansible-docker/blob/master/templates/etc/systemd/system/docker.service.j2#L17. If it's empty, nothing gets output, otherwise it creates options out of the list passed in.

I don't think we really need to change it.

from ansible-docker.

riteshpuj2013 avatar riteshpuj2013 commented on June 12, 2024

Yes @nickjj, that makes sense.
Thank you for the info.

from ansible-docker.

nickjj avatar nickjj commented on June 12, 2024

No problem. On paper, writing out the json file is a better solution but I do feel it complicates things for little benefit in this specific case.

from ansible-docker.

riteshpuj2013 avatar riteshpuj2013 commented on June 12, 2024

Thanks for the info and sharing the code @nickjj.

from ansible-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.