Copied code about zhong HOT 5 CLOSED

@mperham I definitely remember looking at Sidekiq code for some of the Redis handling stuff, but, most of this was written over a year ago -- could you please advise specifically which sections of code you are referencing?

I have no real problem with re-licensing the library as LGPL -- what would you recommend? I am happy to contribute back any changes I made that could be useful to Sidekiq, as well (and thank you again for your hard work on that project!).

I edited your comment to remove the duplicate FYI :)

from zhong.

(FWIW the project upon which this was based and is roughly compatible with was Clockwork, just for another point of comparison)

from zhong.

web.rb and web_helpers.rb are essentially older copies of Sidekiq code, including comments I wrote myself.

https://github.com/nickelser/zhong/blob/master/lib/zhong/web_helpers.rb
https://github.com/nickelser/zhong/blob/master/lib/zhong/web.rb#L73

I prefer to use LGPL licensing for my OSS, as it ensures no one else can create a closed source fork of my project but YMMV. If you want to keep that code, just relicense. Otherwise, delete those files and reimplement from scratch.

from zhong.

@mperham sorry about that -- I've gone back, added attribution, and created a PR to re-license the project.

Let me know if you have any other feedback or suggestions, and many apologies for lifting that code without proper licensing. That was a mistake and oversight on my part!

from zhong.

Thanks for being super chill about the whole thing!

from zhong.