Leaks somewhere. about get_next_line HOT 4 OPEN

vukolka commented on August 15, 2024

Leaks somewhere.

from get_next_line.

Comments (4)

nickdotht commented on August 15, 2024

Thanks for the heads up. Will look through it.

…

On Jan 31, 2018 10:42 AM, "Nik" ***@***.***> wrote: Tested my lem-in on a 1mb map with this GNL. Leaks really hard. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADzLiXA06W8yEmQ2oEPfIKfZDJHbRI17ks5tQInCgaJpZM4R0LQU> .

from get_next_line.

Hirza-Tango commented on August 15, 2024

The leak is on line 47 of get_next_line.c

The string is not freed before reallocation with ft_strjoin()

from get_next_line.

nickdotht commented on August 15, 2024

Oh wow... I can't believe I lost track of this issue. Ouch. Will fix soon. Thanks again @vukolka and @1ShotSniper

from get_next_line.

RobertoGalois commented on August 15, 2024

Hello, It's because of your copyuntil function,
By the way, why do you use ft_strjoinch() that allocate a new char* at each loop,
instead of doing an ft_strncpy ?

I mean, instead of that:
while ((src[count] != '\0') && (count < i))
94 {
95 if ((*dst = ft_strjoinch(*dst, src[count])) == NULL)
96 return (0);
97
98 count++;
99 }

You could do that:
90 ft_strncpy(*dst, src, i);

Thank you for your repo btw, It were very helpfull to me for this project

from get_next_line.

Recommend Projects