Comments (9)
Hey @davidjbradshaw,
Thank you for taking the time to file this issue. I'll have to look into the eslint-plugin-json source, but it may be an issue that we both define parsers for JSON. I might be able to change my parser to be more compatible with it.
I'll try to get to this sometime this week.
Cheers,
Nick
from eslint-plugin-no-secrets.
Hey @davidjbradshaw,
Thanks to @constgen and eslint-plugin-jsonc
, we have finally found a workaround to this issue. Essentially, instead of parsing the JSON documents as JS, we extend the existing parser to add new tokens for JSON documents. This means no parsing collisions (unless someone extends the parser with the exact same token names).
Thank You!
Nick
from eslint-plugin-no-secrets.
Hey @davidjbradshaw,
Could you send me the eslint config that caused the issue? I'm finding an issue recreating your exact error (although I've found a different error).
EDIT: Is it eslint-config-adjunct on master
?
Which version of eslint are you using? it seems like this issue may have been addressed here.
Still, I'm facing a different issue than you where it doesn't even get input for the rules, so I might have to file an issue with eslint. Very good find!
Cheers,
Nick
from eslint-plugin-no-secrets.
Yes itβs that project. Should be the latest version of esLint in there, unless it updated in the last few days
from eslint-plugin-no-secrets.
I found the issue in this project, note that is currently setup to load v0.5.4 of your code. So you will need to push that too the latest version to repo this.
https://github.com/davidjbradshaw/eslint-config-adjunct
from eslint-plugin-no-secrets.
Oh my bad, I should have said eslint-plugin-json-format
, rather than eslint-plugin-json
from eslint-plugin-no-secrets.
I found a workaround for me
https://github.com/davidjbradshaw/eslint-config-adjunct/blob/master/rules/no-secrets.js
from eslint-plugin-no-secrets.
Hey @davidjbradshaw,
Thank you for the additional input and I apologizing for the delay in fixing this. Life threw me a bit of a curveball this last month. I have filed an issue with the eslint team (as seen above), and I'm hoping they can help me out. I'm glad you found a workaround.
Best,
Nick
from eslint-plugin-no-secrets.
Thanks for the update and no worries, I hope things are ok now. Just read your eslint ticket, that looks like a can of worms to solve.
from eslint-plugin-no-secrets.
Related Issues (11)
- [feature request] Blacklist particular statements HOT 7
- does this library support ESLint 7? HOT 3
- question: find secrets in comments? HOT 3
- continuous integration HOT 6
- Minimum entropy threshold HOT 3
- Support "Flat Config" (ESLint 9) HOT 7
- specify a delimiter HOT 10
- real entropy HOT 10
- upgrading dependencies HOT 4
- is there a Changelog? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-no-secrets.