Code Monkey home page Code Monkey logo

Comments (3)

chrimesdev avatar chrimesdev commented on June 16, 2024

We will also need to the config option for asset path for the NHS SVG logo fallback for IE8

 <image xlink:href="" src="/assets/logos/fallback/logo-nhs.png"></image>

Currently it points at /assets/logos/fallback/logo-nhs.png but people might not have their assets hosted at the same location.

May be more difficult to do as its a SVG file we need to put the asset path URL in, do we move the SVG fallback to CSS?

from nhsuk-frontend.

mikemonteith avatar mikemonteith commented on June 16, 2024

Could use relative path instead for the svg? If someone can host an .svg, they can probably host a .png somewhere relative to it.

from nhsuk-frontend.

mikemonteith avatar mikemonteith commented on June 16, 2024

Closed because we are avoiding the use of url(...) in our CSS for now.
We only had one background-image, so we will use a base64 encoded string.

For future reference, we shouldn't be using too many base64-encoded strings in our CSS for css-weight reasons. If we get many more background-image icons, this ticket might need to get reopened.

from nhsuk-frontend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.