Comments (3)
We will also need to the config option for asset path for the NHS SVG logo fallback for IE8
<image xlink:href="" src="/assets/logos/fallback/logo-nhs.png"></image>
Currently it points at /assets/logos/fallback/logo-nhs.png
but people might not have their assets hosted at the same location.
May be more difficult to do as its a SVG file we need to put the asset path URL in, do we move the SVG fallback to CSS?
from nhsuk-frontend.
Could use relative path instead for the svg? If someone can host an .svg, they can probably host a .png somewhere relative to it.
from nhsuk-frontend.
Closed because we are avoiding the use of url(...)
in our CSS for now.
We only had one background-image, so we will use a base64 encoded string.
For future reference, we shouldn't be using too many base64-encoded strings in our CSS for css-weight reasons. If we get many more background-image icons, this ticket might need to get reopened.
from nhsuk-frontend.
Related Issues (20)
- a.nhsuk-button.nhsuk-button--reverse:visited text is invisible! HOT 1
- Do not quote nunjucks params in examples HOT 1
- Details and Expander and the `open` param HOT 2
- Action link example links to removed external page
- Skip to main link adds a focus ring to the H1 HOT 1
- Can't apply ids to row keys, values and anchor links on summary list component HOT 1
- Radio buttons/checkboxes cannot be activated by voice activation software
- Use of 2 font-size declarations in css HOT 2
- Deprecation Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. HOT 2
- Error installing NHS.UK frontend using npm HOT 1
- Better documentation for developers extending this package HOT 2
- Font sizes in the header for longer service/org names look too small HOT 1
- Example/demo needed for an organisational header with logoURL macro in use HOT 1
- Header navbar with too many/too few items HOT 4
- Header/Footer samples on component site out of date with latest compiles CSS HOT 2
- Header container responds differently to width container
- Header logo "Content with images must be labeled" accessibility warning on firefox HOT 1
- 'Primary Card (With Chevron)' issue while hovering over chevron image HOT 2
- Buttons added after domready don't get button JS behaviour bound to them
- .nhsuk-width-container-fluid class is no longer working as expected. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nhsuk-frontend.