Code Monkey home page Code Monkey logo

Comments (13)

couzic avatar couzic commented on May 22, 2024 2

Nice ! 👍
However, just to stay on the safe side, maybe we could ask someone close to or in the angular team if it is a good idea ?

from ngx-formly.

mohammedzamakhan avatar mohammedzamakhan commented on May 22, 2024 2

I am thinking about

import {} from "formly"; 

or

import{} from "formly-bootstrap"

or

import {} from "formly-ionic"

or

import {} from "formly-material"

from ngx-formly.

robwormald avatar robwormald commented on May 22, 2024 1

i wouldn't do this just for the sake of it, unless you really have a need to break out into smaller packages that are functionally independent - it's a non-trivial amount of work managing the process.

It makes sense for things like @ngrx or @Material because they have a number of independently functional components or services, that can be independently distributed.

I'm not saying don't, just... consider if you really need to do this.

from ngx-formly.

TheMcMurder avatar TheMcMurder commented on May 22, 2024

I actually like this idea. I think we're going to see a lot of angular specific libraries follow this convention.

from ngx-formly.

mohammedzamakhan avatar mohammedzamakhan commented on May 22, 2024

@pkozlowski-opensource @johnpapa @gdi2290 @robwormald

Can you guys help us in this decision.

Thanks in advance 😄

from ngx-formly.

PatrickJS avatar PatrickJS commented on May 22, 2024

import {} from 'ng2-formly';

from ngx-formly.

mohammedzamakhan avatar mohammedzamakhan commented on May 22, 2024

@gdi2290 I saw even material2 started using @

import { MD_CARD_DIRECTIVES } from '@angular2-material/card';

Just wondering if the angular team is going to get rid of @ in the future releases or whats the reason you don't want formly to use @.

Thanks 👍

from ngx-formly.

PatrickJS avatar PatrickJS commented on May 22, 2024

yeah I think you're looking for something like
@formly/ng2
| @formly/directives
| @formly/templates
| @formly/core
where @formly/core is used both in other frameworks. If you don't plan on supporting other frameworks then @formly/core works as the default path for ng2.

from ngx-formly.

PatrickJS avatar PatrickJS commented on May 22, 2024

I want this to be able to render on the server/webworker so it would also be great if you separated the platform logic and interacted with the renderer directly

from ngx-formly.

mohammedzamakhan avatar mohammedzamakhan commented on May 22, 2024

@gdi2290 Thats in our pipeline :) ( #53 )

Thanks for your suggestion

from ngx-formly.

mohammedzamakhan avatar mohammedzamakhan commented on May 22, 2024

@robwormald

I think it makes sense for our repo to have separate functional components, since we want to have templates are separate, and again the templates could be of bootstrap, ionic, material2 or any other.

Thanks a lot

from ngx-formly.

mohammedzamakhan avatar mohammedzamakhan commented on May 22, 2024

To publish with @, npm will require us to make an organization which is paid on npm, so I think we should think about something else instead 😭

from ngx-formly.

TheMcMurder avatar TheMcMurder commented on May 22, 2024

I would prefer something like

import {} from 'formly/templates/bootstrap'

all templates could go in the template/${frameworkName} directory for each css framework that is supported.

I'm still pretty new to publishing things on NPM but couldn't we follow the same structure you had planned without the @?

from ngx-formly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.