feature request: a simpler logging service accepting log message and log payload about lumberjack HOT 10 CLOSED

Sorry, @santoshyadavdev I missed this notification. Go ahead with this idea POC. :)

from lumberjack.

@pBouillon

The partial implementation suggested doesn't quite make sense since scope isn't known in this example. This is something work discussing. Should log scope be part of this API?

I'm still new to the process, what do you mean by drafting and testing this?

I mean feel free to start writing code, tests, documentation, and design documents and we will help you rework your contribution after the framework-agnostic release of Lumberjack.

Should I wait for the v16 and suggest changes then, based on the rework or write what the API might look like

You can get started on the Angular API for now. We will need to adapt it to the framework-agnostic package, @lumberjackjs/core, after the framework-agnostic release.

without referencing inject since it is Angular-related?

We will still have Angular-specific packages:

• @lumberjackjs/angular
• @lumberjackjs/angular-http-driver

from lumberjack.

Do we need to create a new service, or can we expose the functions?

WDYT @LayZeeDK @NachoVazquez

we can do logCritical(params) {
const service = inject(LoggerService).log()
}

from lumberjack.

I don't completely follow. Could you describe the usage API?

from lumberjack.

The API will look like

export function logCritical(message: string, payload: LumberjackLogPayload) {
  return inject(LumberjackService).log({
    message: message,
    payload: payload,
    level: LumberjackLevel.Critical,
    createdAt: Date.now(),
    scope: 'Forest App',
  });
}

And we can use it like below.

logCritical('The forest is on fire', { angularVersion: VERSION.full })

from lumberjack.

I think that's interesting. We could definitely iterate over the idea.

Good thoughts

from lumberjack.

Great, should I try to create a POC and open a PR with this idea? Or do we want to go with Services in the first iteration?

from lumberjack.

Hey! Is this issue still open? I'd like to help and looking for a starting point 😄

from lumberjack.

Hi @pBouillon

Yes, this is still open and relevant. We are currently working on a major rework of Lumberjack to make it framework-agnostic (see #166) so we won't accept any features or publish new feature releases before that work is done. But please feel free to draft design documents, implementation, and tests for this feature and we can iterate over it after the breaking changes and package expansion.

from lumberjack.

I'm still new to the process, what do you mean by drafting and testing this? Should I wait for the v16 and suggest changes then, based on the rework or write what the API might look like, if not what @santoshyadavdev already suggested but without referencing inject since it is Angular-related?

On a side note, this is a huge refacto, good luck! 🙌

from lumberjack.