Code Monkey home page Code Monkey logo

Comments (6)

alessfg avatar alessfg commented on August 17, 2024 1

Heya! Can you pull the latest version of the image and let me know if that works? The scripts should no longer need write access to nginx.conf 😄

from docker-nginx-unprivileged.

eerotki avatar eerotki commented on August 17, 2024

Indeed, this certainly is fixed with the latest version. I should had made certain that no old images are being used before posting this issue. Oh well, happens.

Thanks for the quick reply and your help!

from docker-nginx-unprivileged.

jalaziz avatar jalaziz commented on August 17, 2024

It seems that write access is required for nginx.conf in the latest version. I get that it's required for the scripts to modify the file, but isn't providing write access to nginx.conf to the nginx user technically a security risk?

That being said, I can't think of a great solution other than possible some suid hackery.

from docker-nginx-unprivileged.

alessfg avatar alessfg commented on August 17, 2024

Truth be told, I can't find what alleged fix was introduced to initially solve this issue, and it's been long enough that I have totally forgotten.

You are right that the image as is requires write access to nginx.conf. This adds quite a bit of adaptability insofar as supported environments goes, and, in theory this should not be a security issue if you are running the images as intended. That being said, there might be a case for providing a less customizable and more restricted image.

from docker-nginx-unprivileged.

jalaziz avatar jalaziz commented on August 17, 2024

in theory this should not be a security issue if you are running the images as intended.

Well, even when running as intended, if an attacker discovered an exploit wouldn't it be theoretically be possible to change the config maliciously and force a reload? Or is that impossible?

from docker-nginx-unprivileged.

alessfg avatar alessfg commented on August 17, 2024

It would be theoretically possible, although at that stage changing the NGINX config would probably be one of your lesser worries.

But, like I said, you raise a valid point for providing a more restricted image. I don't know that it'll 100% happen, or when it will happen, if it does happen, but it's definitely an option to be explored.

In the meantime, and if it's something you'd really like to see implemented, PRs are always more than welcome!

from docker-nginx-unprivileged.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.