Code conventions about ng-bootstrap HOT 6 CLOSED

Personally, I like what @pkozlowski-opensource did on pagination, but I would add more typing (even if it is not really needed). Like those number variables that are initialized but they don't have typing.

from ng-bootstrap.

Tests conventions:

I think we should write two big describe blocks. One to test the directive behavior (without UI) like we used to do with Angular 1 and then another big describe block to test the UI too.

What do you thing? We should do the same for all of them, so better if we lay some conventions.

from ng-bootstrap.

@Foxandxss you are raising many valid points here but IMO it would be easier to discuss those if we would have a separate issue for each point (and a label to find all those issues)

from ng-bootstrap.

What do you suggest? An issue for component conventions and another one for test conventions?

To be honest, I don't think one issue like this is too messy. We just need to settle some basic conventions between us so our component and tests follow the same ideas.

from ng-bootstrap.

What do you suggest?

One issue per item to discuss. I can see 4 separate issues here :-)

To be honest, I don't think one issue like this is too messy

I'm not saying it is messy - I'm just saying it would be far easier for me to focus on individual items rather that having a conversation about everything in one issue.

from ng-bootstrap.

Sure mate, will do that right now.

from ng-bootstrap.