Comments (3)
Perhaps we could add a "key" attribute that would allow overwriting parent tags with the same key? I think it would be pretty easy to implement, and it would allow opting-in for a specific, non-standard replacement (thinking about JSON Schema script tags here)
from react-helmet.
Currently, if you are trying to render a tag like this: <link rel="icon" type="image/x-icon" href="http://example.com/favicon.ico" />
the primary attribute for the tag would be the href
, so if the parent and child have different hrefs, it will render both.
This use case is not currently handled. Thanks for bringing it to our attention. I know we have a rule for canonical links. I think we can make the check more general to say any tags with the same rel
except for stylesheets will be considered equal. And thus, the child component can overwrite it.
If we switch the statement to always overwrite if the rel
values are the same, we'll need to call out ALL exceptions that cascade, like stylesheet
.
from react-helmet.
@emilecantin I have another idea to solve this problem by setting preserved
explicitly like this way:
<Helmet preserved>
<link rel="apple-touch-icon" sizes="192x192" href="touch-icon.png">
<link rel="apple-touch-icon" sizes="256x256" href="touch-icon-large.png">
</Helmet>
<Helmet preserved={false}>
<meta name="description" content="category of my site" />
</Helmet>
from react-helmet.
Related Issues (20)
- Not properly working with new React18 root-api HOT 5
- Insert script tags in the <head> from CMS
- [RFF] Avoid Code Duplication
- Send Link
- is it safe? HOT 1
- Strange behavior with body className HOT 1
- How to add meta tags which I first need to fetch HOT 1
- Multiple `<Helmet>` tags will break (only one will render) HOT 3
- I recently used react helmet for changing title of all route links its perfectly working but the title is not change source code plz resolve this issue HOT 1
- Active support HOT 4
- How do I append a value to the title? HOT 3
- Warning 'UNSAFE_componentWillMount', How to fix the problem? HOT 4
- the meta tags is shown in page sourse but not shown in social media share,, any help? HOT 2
- local script and CSS file not working in React-Helmet HOT 1
- React Helmet Meta descriptions are not updated on Google Search HOT 1
- Do react-helmet support ESM tree shaking?
- Analysis: 68% of dependency updates in this repository can be merged.
- Bug: cannot remove/clear document title HOT 2
- The module 'Helmet' cannot be used as a JSX component. HOT 1
- Bug: Destructure Fragments
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-helmet.