Code Monkey home page Code Monkey logo

Comments (6)

dmalzl avatar dmalzl commented on August 12, 2024 1

i opened an issue with them now.
ncbi/sra-tools#865 (comment)

from fetchngs.

lindenb avatar lindenb commented on August 12, 2024 1

I got the same bug, (and my email , full of dots, is in my path...). If fixed this on my side for paired-ends reads with the following code for fetchngs/modules/nf-core/sratools/fasterqdump/main.nf

   mkdir -p TEST.OUT TEST_1.OUT TEST_2.OUT
    fasterq-dump \\
        $args \\
        --threads $task.cpus \\
        --outfile TEST.OUT/$outfile \\
        ${key_file} \\
        ${sra}

    mv -v "TEST_1.OUT/${outfile}"  ./${outfile}.1.fastq
    mv -v "TEST_2.OUT/${outfile}"  ./${outfile}.2.fastq

    pigz \\
        $args2 \\
        --no-name \\
        --processes $task.cpus \\
        *.fastq
(...)

from fetchngs.

drpatelh avatar drpatelh commented on August 12, 2024 1

This should be fixed in the next pipeline release by downgrading the version of sratools until it is fixed upstream. See #261

I will leave this issue open until then as fixing upstream is the desired resolution. In the meantime, anyone wanting to use more recent support for ngc files can use sratools v3.0.8 via a custom config file passed to the pipeline:

process {
    withName: 'SRATOOLS_FASTERQDUMP' {
        container = 'quay.io/biocontainers/mulled-v2-5f89fe0cd045cb1d615630b9261a1d17943a9b6a:2f4a4c900edd6801ff0068c2b3048b4459d119eb-0'
    }
}

from fetchngs.

dmalzl avatar dmalzl commented on August 12, 2024

looking at the code and the actual command.sh file (see below) I actually think this is a fasterq-dump issue because the error message seems to be printed by fasterq-dump

#!/bin/bash -euo pipefail
export NCBI_SETTINGS="$PWD/user-settings.mkfg"

fasterq-dump \
    --split-files --include-technical \
    --threads 6 \
    --outfile SRX10737613_SRR14385311 \
     \
    SRR14385311

pigz \
     \
    --no-name \
    --processes 6 \
    *.fastq

cat <<-END_VERSIONS > versions.yml
"NFCORE_FETCHNGS:SRA:FASTQ_DOWNLOAD_PREFETCH_FASTERQDUMP_SRATOOLS:SRATOOLS_FASTERQDUMP":
    sratools: $(fasterq-dump --version 2>&1 | grep -Eo '[0-9.]+')
    pigz: $( pigz --version 2>&1 | sed 's/pigz //g' )
END_VERSIONS

from fetchngs.

drpatelh avatar drpatelh commented on August 12, 2024

I am able to reproduce this locally when running nf-test:

nf-test test --verbose --tag sra_default_parameters  --profile test,docker

from fetchngs.

drpatelh avatar drpatelh commented on August 12, 2024

As outlined in ncbi/sra-tools#865 (comment) fasterq-dump is unable to resolve paths that contain a . for writing the output files.

from fetchngs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.