Comments (9)
Thanks @Jerome-Herbinet, then I would indeed agree with your suggestion "Convert guest to regular account".
Also the sorting seems off. Destructive actions should always be at the bottom, ideally separated by a divider. Like so:
- Resend welcome email
- Convert gues to regular account
- (Divider)
- Disable account
- Disconnect all devices and delete local data
- Delete account
from guests.
Thanks @Jerome-Herbinet, then I would indeed agree with your suggestion "Convert guest to regular account".
Also the sorting seems off. Destructive actions should always be at the bottom, ideally separated by a divider. Like so:
* Resend welcome email * Convert gues to regular account * (Divider) * Disable account * Disconnect all devices and delete local data * Delete account
@jancborchardt I'll take care of the wording change in a PR, but I won't change menu's entries' order (I think I don't have the required skills).
from guests.
@Pytal what do you think ?
from guests.
In the meantime, a colleague has told me that from a technical point of view it looks like a new user is created, and the old guest is deleted. Can you confirm this?
Nevertheless, I stand by my original request from a UI/UX POV, as I think the notion of conversion is easier to understand, especially as if you enter a username that already exists, you can't continue the process. Also, it would avoid some confusion, for example the fact that folders can be transferred from user settings ("Transfer ownership of a file or folder "). In other words, the transfer notion exists elsewhere and we must not create confusion.
from guests.
In the meantime, a colleague has told me that from a technical point of view it looks like a new user is created, and the old guest is deleted. Can you confirm this?
Yes, this is correct. Under the hood a new user is created and the guest user data is transferred to it before being deleted.
Overall no strong opinion though, I think we should get @nextcloud/designers input on the naming :)
Finally, I've noticed a problem, unless it's deliberate. The quota doesn't change and remains zero; shouldn't the conversion apply the “default” quota to the user after conversion?
Could you split this off into a separate issue? 🙏
from guests.
In the meantime, a colleague has told me that from a technical point of view it looks like a new user is created, and the old guest is deleted. Can you confirm this?
Yes, this is correct. Under the hood a new user is created and the guest user data is transferred to it before being deleted.
Overall no strong opinion though, I think we should get @nextcloud/designers input on the naming :)
Finally, I've noticed a problem, unless it's deliberate. The quota doesn't change and remains zero; shouldn't the conversion apply the “default” quota to the user after conversion?
Could you split this off into a separate issue? 🙏
@Pytal thanks for your answer. Concerning the quota, here is the separate issue : #1226
from guests.
Would "change" be even simpler wording? @Jerome-Herbinet could you show where this wording occurs in context and the change you suggest?
from guests.
how where this wording occurs in context and the change you suggest?
@jancborchardt check the screenshot below. Also, I wonder if "full" is relevant. Suggestion instead : "regular", because "full" word could make admin think about some extra privileges, which is not the case.
from guests.
Wording change PR : #1228
from guests.
Related Issues (20)
- Guests needs application system folders
- Guests App will not be compatible with NC29 in its current state
- `occ guests:list` execute return type exception
- Guests have no access to shared folders in NC28 HOT 5
- Guests cannot invite other guests inside their circle to planned meetings
- Unable to create and add files and folders HOT 12
- App restrictions in the admin UI don't wrap
- Deleted files do not show up in trashbin of guest users
- Guest users cannot upload files in their root folders even if they have quota HOT 1
- Shared Calenders for Guest Users HOT 1
- Custom permissions to disallow downloads doesn't allow files to be opened in readers
- Guests w/o password to permit auto-login via a link
- Convert existing users to guest users HOT 1
- Missing index for guest display name lookup
- when share_folder parameter is set in config.php, guests are unable to see incoming shares as the share_folder define cannot be created HOT 2
- How to add guests to Collectives HOT 3
- Sharing folders will sent email share accept invites, which are causing issues
- Not able to create or assign user to Guests group HOT 2
- After transfer process, the new regular user still has a "0" quota
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from guests.