Code Monkey home page Code Monkey logo

Comments (5)

burningthumb avatar burningthumb commented on August 14, 2024 2

I ran this code (without Retrofit) and it threw the exception:

The 'OCS-APIREQUEST' header will be automatically added by the Nextcloud SSO Library. Please remove the header before making a request

So I changed it as follows:

NextcloudRequest nextcloudRequest = new NextcloudRequest.Builder()
            .setMethod("GET")
            .setUrl("/ocs/v2.php/cloud/capabilities")
            .setParameter(params)
// comment out            .setHeader(header)
            .build();

And it worked for me.

from android-singlesignon.

David-Development avatar David-Development commented on August 14, 2024 1

@burningthumb Thanks for testing this on your end!

That seems about right. Since Rob already tested the request, I remember adding this check to the nextcloud side in order to prevent users setting this flag twice as it should be present on all requests anyways.. (and setting it twice causes problems as far as I remember)

I'm not sure why you didn't get the same error message as Rob. I'm checking if the header is present using equalsIgnoreCase as seen here:
https://github.com/nextcloud/android/blob/8955709705a8ae937403b1102a1d11cccc6b9258/src/main/java/com/nextcloud/android/sso/InputStreamBinder.java#L286

Which version of the nextcloud files app are you using? Maybe it's an outdated version? The feature was added on the 21st of may (and released sometime after that).

from android-singlesignon.

desperateCoder avatar desperateCoder commented on August 14, 2024

Indeed, it also works with the Retrofit request builder, just by removing the header...

Also, my nextcloud app on my virtual device was quite outdated, so you were both right! So thanks @burningthumb and @David-Development! Works like a charm now!

from android-singlesignon.

desperateCoder avatar desperateCoder commented on August 14, 2024

Oh, one more thing: after the update of the Nextcloud app i got the same message as @burningthumb.

from android-singlesignon.

tobiasKaminsky avatar tobiasKaminsky commented on August 14, 2024

Nice, thanks @burningthumb for debugging 👍

from android-singlesignon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.