Headers not sent? about android-singlesignon HOT 8 CLOSED

@desperateCoder Yeeay, great 👍 🎉

from android-singlesignon.

Thanks buddy! It even works! if i set the Date to now, no results are returned by the server.
Now, go and get a Cooke, you deserved one!

from android-singlesignon.

@desperateCoder Thanks for the report. Just looked into it again and indeed it looks like that the headers are not send (nor processed).. reference: https://github.com/nextcloud/android/blob/b31d650b28fa3819f7076f1d1464369852ed0fb5/src/main/java/com/nextcloud/android/sso/InputStreamBinder.java#L165

I'll look into it!

from android-singlesignon.

Great, thanks for your support!

from android-singlesignon.

Like a charm! Look what we got here!

from android-singlesignon.

For sure, glad to see that you guys are still using it! And this is how we make this SingleSignOn library even better! :)

Just created a PR in the nextcloud-android repo as it needs to be fixed there. Is it possible for you to test the fix before we merge it? (nextcloud/android#3330).

I don't have a proper testing-environment here to test if the headers are send properly.

from android-singlesignon.

It is very convenient to use it, so there is no reason not to... :) Why struggle over self signed certs or that kind of problems?!?

Sure, i can test it, but don't i have to update the SSO-Libs as well? Which version should i include?
My current version is:

implementation 'com.github.nextcloud:android-SingleSignOn:0.1.2'

from android-singlesignon.

That is very true! :)

but don't i have to update the SSO-Libs as well

No, no need to update dependencies. Just run/compile the updated nextcloud-files apk and that should do the trick ;-)

(download the https://github.com/nextcloud/android repo, checkout the branch sso-fix-request-header and compile/install).

from android-singlesignon.