Add codacy checks to pull requests? about android-singlesignon HOT 11 CLOSED

I added Android SSO (and Android News) to the codacy checked repositories

Awesome!! Thank you 👍

Should I also add the codacy checks to the PRs like we do for the files app and the android library repositories?

I'm not sure if I get the question correctly. This repository (Android-SingleSignOn) as well as the news-android repository don't have open PR's anymore. It's already merged on master (in both repositories).

from android-singlesignon.

I'm not sure if I get the question correctly.

My question is if I should activate "codacy for PRs" for the repositories. If I do this will be a PR check run on every (future) PR which would block merges (except for forced, admin merges) if codacy detects any new issues caused by the PR in comparison to the master branch. (Like you see in the files app repo for the SSO branch/PR)

from android-singlesignon.

@David-Development I also invited you to the codacy admin team. This way you can always set issues to be ignored or customize the rules that get checked e.g. for pmd, checkstyle, etc. :)

from android-singlesignon.

Yes, I think we should enable this.
And, as dev speed slows down, also prevent pushing directly to master.

from android-singlesignon.

Yes, I think it's a good idea to keep code quality up! :) I'll try to fix some code-quality issues later today!

from android-singlesignon.

@tobiasKaminsky can you activate the post commit hook in codacy? I do not have any rights on the repos atm.

from android-singlesignon.

Should be done.
It may need to be enabled as required status after creating a PR.
Just ping me, if a PR is open and codacy is not fully working.

from android-singlesignon.

@tobiasKaminsky please also activate it for Android News client :) ❤️

from android-singlesignon.

@David-Development can you then please invite @nextcloud-android-bot and make him an admin in your repo?

from android-singlesignon.

@tobiasKaminsky to the nextcloud/news-android repo on GitHub? I don't have admin right there..

from android-singlesignon.

No problem, nextcloud-android-bot is added and codacy is now working 👍

from android-singlesignon.