Comments (5)
@nmala01 thanks for bringing this to our attention. We're not able to commit to changing this at the moment but it's a good suggestion
Since your code is fresh in your mind, would you be willing to provide a sample app that reproduces the problem?
from newrelic-telemetry-sdk-java.
Imagine if a logging framework threw an exception and ended up rolling back a transaction or ending a procedure early. It would not look good, and try/catch every log call is not feasible.
The point here is that both logging and New Relic are 3rd parties that should not prevent the main application from functioning.
That does not mean it is not a good idea to have a method that can allows to treatment of an exception.
So ideally there should be 2 methods:
- one that only logs;
- one that throws checked exceptions.
Implementation wise, the logging method should call the exception method, catch the exception, log it and continue the flow.
from newrelic-telemetry-sdk-java.
@meiao I understand that 3rd parties should not prevent main application from functioning, but data loss is such a crucial error that just logging it seems like a bug.
Also the option for logging or throwing exception can be handled using the NotificationHandler if appropriate exception get thrown to TelemetryClient.
from newrelic-telemetry-sdk-java.
https://issues.newrelic.com/browse/NEWRELIC-4094
from newrelic-telemetry-sdk-java.
Unfortunately, we were not able to prioritize this for the next (Jan-Mar) quarter. Will consider for a future quarter.
from newrelic-telemetry-sdk-java.
Related Issues (20)
- Memory leak in OT Tracing 0.4.1 / 0.6.1 HOT 2
- Consider dropping old data when telemetry size limit is reached. HOT 1
- Assistance in querying data HOT 2
- Follow up on license/api key conversation HOT 4
- NullPointerException using the telemetry-all dependency HOT 1
- Update README with Github release process
- CVE in telemetry-http-okhttp dependency HOT 5
- Java11HttpPoster does not silently retry network errors like OkHttpParser HOT 1
- Need full stack trace to diagnose connectivity issues HOT 4
- Question/Suggestion -> How are the telemetry SDKs expected to be used in Serverless Function architectures? HOT 1
- Telemetry SDK does not support Metrics API v2 HOT 2
- Not handled error response codes by BatchDataSender HOT 3
- CVE-2022-25647 HOT 1
- Impossible to provide executor for scheduler for TelemetryClient HOT 5
- [Repolinter] Open Source Policy Issues HOT 1
- Update okhttp3 HOT 4
- Update release action to use Node 16 HOT 1
- Cannot include both dependencies `telemetry-http-okhttp` and `telemetry-core` in `build.gradle` HOT 2
- Need to upgrade OKHTTP versions HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from newrelic-telemetry-sdk-java.