Code Monkey home page Code Monkey logo

Comments (5)

kford-newrelic avatar kford-newrelic commented on June 25, 2024

@nmala01 thanks for bringing this to our attention. We're not able to commit to changing this at the moment but it's a good suggestion

Since your code is fresh in your mind, would you be willing to provide a sample app that reproduces the problem?

from newrelic-telemetry-sdk-java.

meiao avatar meiao commented on June 25, 2024

Imagine if a logging framework threw an exception and ended up rolling back a transaction or ending a procedure early. It would not look good, and try/catch every log call is not feasible.

The point here is that both logging and New Relic are 3rd parties that should not prevent the main application from functioning.

That does not mean it is not a good idea to have a method that can allows to treatment of an exception.

So ideally there should be 2 methods:

  • one that only logs;
  • one that throws checked exceptions.

Implementation wise, the logging method should call the exception method, catch the exception, log it and continue the flow.

from newrelic-telemetry-sdk-java.

nmala01 avatar nmala01 commented on June 25, 2024

@meiao I understand that 3rd parties should not prevent main application from functioning, but data loss is such a crucial error that just logging it seems like a bug.
Also the option for logging or throwing exception can be handled using the NotificationHandler if appropriate exception get thrown to TelemetryClient.

from newrelic-telemetry-sdk-java.

workato-integration avatar workato-integration commented on June 25, 2024

https://issues.newrelic.com/browse/NEWRELIC-4094

from newrelic-telemetry-sdk-java.

kford-newrelic avatar kford-newrelic commented on June 25, 2024

Unfortunately, we were not able to prioritize this for the next (Jan-Mar) quarter. Will consider for a future quarter.

from newrelic-telemetry-sdk-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.