Comments (12)
You should still release a v2.5.0 of this with the pinned CLI version. I appreciate that the CLI rollback will fix the 2.4.0 version that everyone is using for now, but that doesn't address the floating dependency problem.
Every single time someone runs this action, they are taking the latest release of the CLI container at that moment. As we found today, that is not always a good thing.
This is a stable solution that I will use until you tag a new release:
from deployment-marker-action.
PR opened to fix this by pinning the cli. I'd argue it should always be pinned and handled like the dependency it is.
from deployment-marker-action.
The action is setup to float to the latest version of the newrelic/cli container and that is now on v0.74 of the cli.
Unfortunately the latest cli version is expecting a property from their graphql api (NerdGraph), which isn't live yet. Either they need to deploy the updated graphql api or roll back the cli to not ask for the missing property.
Not much you can do about this since they deployed a change in their client before the server, and allow the action to float to latest client.
from deployment-marker-action.
@barryhagan v2.5.0 is out with your change to pin the version
from deployment-marker-action.
Can confirm, we just ran into the same issue earlier.
from deployment-marker-action.
I can confirm, we have the same issue too
from deployment-marker-action.
I don't see any recent commits to the action that might explain this so this is most likely a breaking change in the API ?
from deployment-marker-action.
yeah, this PR was merged in 4 hours ago, causing this issue 🤦
from deployment-marker-action.
Sorry about that everyone. A version of the CLI went out today with an API that is not yet GA. I merged @barryhagan's PR to pin the CLI to the previous version hopefully unblocking you all.
from deployment-marker-action.
@mbazhlekova i think this will still be an issue until there is a new release of this repo. And for anyone who has pinned to the current point release, wont it require a new release of the cli docker container?
from deployment-marker-action.
@benburkert - yeah, it is still an issue if you are using the versioned action like this:
uses: newrelic/[email protected]
There needs to be a new release/tag to get an action version that is pinned to the working cli. You should be able to workaround this immediately by specifying the main branch until there is a tagged release after my PR. (a temporary fix, not recommended long term):
uses: newrelic/deployment-marker-action@main
Alternatively, just reference the commit hash directly:
uses: newrelic/deployment-marker-action@cd8b5c28275fac9b05f66df6f025090072612bb8
from deployment-marker-action.
Actually we're going to release a new version of the CLI without the commit that's causing the problem to get around having to update the deployment marker version.
from deployment-marker-action.
Related Issues (20)
- Does this show up in our Slack channel for github issues?? It better HOT 2
- How to debug 403 response returned? HOT 1
- Not specifying a region can lead to confusing error message HOT 6
- Recommendation for deployment markers in containerized environment (Fargate) HOT 1
- All APM's Deployment Marker HOT 2
- FR - add `commit` field for inputs HOT 1
- Question: Any way to retrieve the generated deployment id? HOT 3
- Question: How to solve a Fatal Error "maximum retries reached: An error occurred resolving this field"? HOT 1
- Action fails but is marked as success HOT 5
- Doc says deploymentType, but input says deploymenttype HOT 1
- could not initialize New Relic client HOT 3
- New Relic Markers clarification on timelines
- Minimum required fields documentation incorrect HOT 2
- NRQL query for deployment marker
- Action is not working for manual run(workflow_dispatch) actions HOT 1
- Fatal error didn't mark the task execution as failed HOT 2
- Ability to send multiple guid in the same call
- Question or feature request: Why we can't use service name instead of GUID?
- Action fails with "Unrecognized named-value 'github'" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deployment-marker-action.