Code Monkey home page Code Monkey logo

Comments (12)

barryhagan avatar barryhagan commented on June 19, 2024 5

You should still release a v2.5.0 of this with the pinned CLI version. I appreciate that the CLI rollback will fix the 2.4.0 version that everyone is using for now, but that doesn't address the floating dependency problem.

Every single time someone runs this action, they are taking the latest release of the CLI container at that moment. As we found today, that is not always a good thing.

This is a stable solution that I will use until you tag a new release:
image

from deployment-marker-action.

barryhagan avatar barryhagan commented on June 19, 2024 3

PR opened to fix this by pinning the cli. I'd argue it should always be pinned and handled like the dependency it is.

from deployment-marker-action.

barryhagan avatar barryhagan commented on June 19, 2024 2

The action is setup to float to the latest version of the newrelic/cli container and that is now on v0.74 of the cli.

Unfortunately the latest cli version is expecting a property from their graphql api (NerdGraph), which isn't live yet. Either they need to deploy the updated graphql api or roll back the cli to not ask for the missing property.

Not much you can do about this since they deployed a change in their client before the server, and allow the action to float to latest client.

from deployment-marker-action.

mbazhlekova avatar mbazhlekova commented on June 19, 2024 1

@barryhagan v2.5.0 is out with your change to pin the version

from deployment-marker-action.

dmrwebdev avatar dmrwebdev commented on June 19, 2024

Can confirm, we just ran into the same issue earlier.

from deployment-marker-action.

fbuzila-g2 avatar fbuzila-g2 commented on June 19, 2024

I can confirm, we have the same issue too

from deployment-marker-action.

tcarac avatar tcarac commented on June 19, 2024

I don't see any recent commits to the action that might explain this so this is most likely a breaking change in the API ?

from deployment-marker-action.

jackie-linz avatar jackie-linz commented on June 19, 2024

yeah, this PR was merged in 4 hours ago, causing this issue 🤦

newrelic/newrelic-cli#1526

from deployment-marker-action.

mbazhlekova avatar mbazhlekova commented on June 19, 2024

Sorry about that everyone. A version of the CLI went out today with an API that is not yet GA. I merged @barryhagan's PR to pin the CLI to the previous version hopefully unblocking you all.

from deployment-marker-action.

benburkert avatar benburkert commented on June 19, 2024

@mbazhlekova i think this will still be an issue until there is a new release of this repo. And for anyone who has pinned to the current point release, wont it require a new release of the cli docker container?

from deployment-marker-action.

barryhagan avatar barryhagan commented on June 19, 2024

@benburkert - yeah, it is still an issue if you are using the versioned action like this:

  uses: newrelic/[email protected]

There needs to be a new release/tag to get an action version that is pinned to the working cli. You should be able to workaround this immediately by specifying the main branch until there is a tagged release after my PR. (a temporary fix, not recommended long term):

  uses: newrelic/deployment-marker-action@main

Alternatively, just reference the commit hash directly:

  uses: newrelic/deployment-marker-action@cd8b5c28275fac9b05f66df6f025090072612bb8

from deployment-marker-action.

mbazhlekova avatar mbazhlekova commented on June 19, 2024

Actually we're going to release a new version of the CLI without the commit that's causing the problem to get around having to update the deployment marker version.

from deployment-marker-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.