NTS 2.0+3.5 builds broken about nettopologysuite HOT 25 CLOSED

Hmm... not sure how to fix this...

from nettopologysuite.

I am no expert on msbuild, but could the actual code content be extracted to a .targets file and referenced within two or more projects (each configured for the appropriate framework) which each have their own .packages file with appropriate targets? (http://msdn.microsoft.com/en-GB/library/92x05xfs.aspx) Then TC can be configured with multiple build steps to build each project before packaging at the end?

Cheers jd

from nettopologysuite.

We have to break the BuildRelease target into several, one for each framework we want to compile for.
Have a look at https://github.com/FObermaier/SbnSharp/blob/master/SharpSbn.targets
Felix

John Diss [email protected] hat am 28. August 2014 um 11:03 geschrieben:
I am no expert on msbuild, but could the actual code content be extracted to a .targets file and referenced within two or more projects (each configured for the appropriate framework) which each have their own .packages file? (http://msdn.microsoft.com/en-GB/library/92x05xfs.aspx) Then TC can be configured with multiple build steps to build each project before packaging at the end?
Cheers jd
From: Ben Abelshausen [mailto:[email protected]]
Sent: 28 August 2014 09:55
To: NetTopologySuite/NetTopologySuite
Subject: Re: [NetTopologySuite] NTS 2.0+3.5 builds broken (#1)
Hmm... not sure how to fix this...
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-53689748.
—Reply to this email directly or view it on GitHub.

from nettopologysuite.

We have to break the BuildRelease target into several, one for each framework we want to compile for.

I'm not sure this should be enough. Actually the problem is related to packages.config inside NetTopologySuite project, so I fear we need to create different projects, only to manage different packages.config files.
Hope a better solutions exists out there...

from nettopologysuite.

dirty, but a prebuild step before each framework compile could clean the build and regex/replace the target in the packages file using variables defined by the project config? Multiple projects and targets feels cleaner though

from nettopologysuite.

prebuild step before each framework

a prebuild step should work, although isn't as simple as I wish

multiple projects and targets feels cleaner though

I agree with targets: having different project files means that we should handle adding/removing of files when someone make a change.

from nettopologysuite.

No, you don't need to do that.
Just change the reference to GeoAPI like this

    <Reference Include="GeoAPI">
      <HintPath>$(SolutionDir)packages\GeoAPI.1.7.2\lib\$(geoApi)\GeoAPI.dll</HintPath>
    </Reference>

All you need to do then is define $(geoApi) in the main property group (if not already defined elsewhere)
:

<geoApi Condition=" '$(geoApi)' == '' ">net40</geoApi>

For the build script that is done in the individual targets.

Sorry if I havn't made myself clear enough.

from nettopologysuite.

Sorry if I havn't made myself clear enough.

ok thanks fot the hint.
so I should edit all projects that references geoapi in this way, right?

hope to try as soon as possible

from nettopologysuite.

ok @FObermaier looks something like this looks ok
in targets file

<Target Name="BuildRelease20">
    <PropertyGroup>
        <fwVersion>net20</fwVersion>
    </PropertyGroup>
    <MSBuild Projects="$(SolutionFile)" 
         Targets="PowerCollections;NetTopologySuite;..." 
         Properties="fwVersion=$(fwVersion);Configuration=Release;..." 
         RunEachTargetSeparately="true" 
         ContinueOnError="true" 
         />     
</Target>  

in csproj files

<fwVersion Condition=" '$(fwVersion)' == '' ">net40-client</fwVersion>  
...
<Reference Include="GeoAPI">
  <HintPath>..\packages\GeoAPI.1.7.3\lib\$(fwVersion)\GeoAPI.dll</HintPath>
</Reference>

now I need only some time to work on it :)

from nettopologysuite.

I think that should do.

from nettopologysuite.

ok I'm in, looks things are working :)

from nettopologysuite.

@FObermaier I've added DependsOn to teamcity.targets because I need to clean before each build

<Target Name="BuildRelease20" DependsOnTargets="CleanRelease">

you've seen some issues related to this?

from nettopologysuite.

Adding DependsOnTargets="CleanRelease" will cause every build output be removed when the next build step starts. I'd say this is not what we want. Instead we can delete the intermediate output for the target before executing the msbuild step:

<Target Name="BuildRelease20">
<PropertyGroup>
<fwVersion>net20</fwVersion>
</PropertyGroup>
<RemoveDir Directories="$(MSBuildProjectDirectory)\obj\v2.0" ContinueOnError="true"/>
<MSBuild Projects="$(SolutionFile)"
Targets="PowerCollections;NetTopologySuite;NetTopologySuite_IO\NetTopologySuite_IO_GeoJSON;NetTopologySuite_IO\NetTopologySuite_IO_ShapeFile;NetTopologySuite_IO\NetTopologySuite_IO_GDB;NetTopologySuite_IO\NetTopologySuite_IO_GeoTools;NetTopologySuite_IO\NetTopologySuite_IO_MsSqlSpatial;NetTopologySuite_IO\NetTopologySuite_IO_PostGis;NetTopologySuite_IO\NetTopologySuite_IO_SpatiaLite;NetTopologySuite_IO\NetTopologySuite_IO_SqlServer2008"
Properties="fwVersion=$(fwVersion);Configuration=Release;TargetFrameworkVersion=v2.0;TargetFrameworkProfile=;DefineConstants=TRACE;NET20;BaseIntermediateOutputPath=$(MSBuildProjectDirectory)\obj\v2.0\;"
RunEachTargetSeparately="true"
ContinueOnError="true"
/>
</Target>

from nettopologysuite.

@FObermaier can you briefly take a look at my changes? hope all is ok now.
I actually still see with UnitTestsPCL: but I wanna move this to another issue.

from nettopologysuite.

Looking good... have been too busy to have look srry...

from nettopologysuite.

@DGuidi that is what I was going to do... you beat me to it.
Looking at the output of v4.5, it seems to be a fake net40. we need to investigate the build log to see what happens.

from nettopologysuite.

@xivk @FObermaier no need to apologize: we try to do our best with the time we have

from nettopologysuite.

@FObermaier checking the msbuild output messages, I see a warning when building for 4.5; it's related to the fact that I haven't the 4.5 framework in my PC, so I simply ignored the warning and considered the build valid.

from nettopologysuite.

For Net45 we need to undefine TargetFrameworkProfile, so the task should look like this:

<Target Name="BuildRelease45">
    <PropertyGroup>
        <fwVersion>net45</fwVersion>
    </PropertyGroup>
    <RemoveDir Directories="$(MSBuildProjectDirectory)\obj\v4.5" ContinueOnError="true"/>
    <MSBuild Projects="$(SolutionFile)" 
         Targets="PowerCollections;NetTopologySuite;NetTopologySuite_IO\NetTopologySuite_IO_GeoJSON;NetTopologySuite_IO\NetTopologySuite_IO_ShapeFile;NetTopologySuite_IO\NetTopologySuite_IO_ShapeFile_Extended;NetTopologySuite_IO\NetTopologySuite_IO_GDB;NetTopologySuite_IO\NetTopologySuite_IO_GeoTools;NetTopologySuite_IO\NetTopologySuite_IO_MsSqlSpatial;NetTopologySuite_IO\NetTopologySuite_IO_PostGis;NetTopologySuite_IO\NetTopologySuite_IO_SpatiaLite;NetTopologySuite_IO\NetTopologySuite_IO_SqlServer2008" 
         Properties="fwVersion=$(fwVersion);Configuration=Release;TargetFrameworkVersion=v4.5;TargetFrameworkProfile=;DefineConstants=TRACE;NET20;NET35;NET40;BaseIntermediateOutputPath=$(MSBuildProjectDirectory)\obj\v4.5\" 
         RunEachTargetSeparately="true" 
         ContinueOnError="true" 
         />
</Target>

EDIT: Unfortunately this applies to GeoAPI and ProjNet as well :(

from nettopologysuite.

@FObermaier using <fwVersion>net45</fwVersion> means that geoapi dll isn't found inside packages folder so I think we should use

<Target Name="BuildRelease45">
    <PropertyGroup>
        <fwVersion>net45-client</fwVersion>
    </PropertyGroup>
    <RemoveDir Directories="$(MSBuildProjectDirectory)\obj\v4.5" ContinueOnError="true"/>
    <MSBuild Projects="$(SolutionFile)" 
         Targets="PowerCollections;NetTopologySuite;NetTopologySuite_IO\NetTopologySuite_IO_GeoJSON;NetTopologySuite_IO\NetTopologySuite_IO_ShapeFile;NetTopologySuite_IO\NetTopologySuite_IO_ShapeFile_Extended;NetTopologySuite_IO\NetTopologySuite_IO_GDB;NetTopologySuite_IO\NetTopologySuite_IO_GeoTools;NetTopologySuite_IO\NetTopologySuite_IO_MsSqlSpatial;NetTopologySuite_IO\NetTopologySuite_IO_PostGis;NetTopologySuite_IO\NetTopologySuite_IO_SpatiaLite;NetTopologySuite_IO\NetTopologySuite_IO_SqlServer2008" 
         Properties="Configuration=Release;TargetFrameworkVersion=v4.5;TargetFrameworkProfile=;DefineConstants=TRACE;NET20;NET35;NET40;BaseIntermediateOutputPath=$(MSBuildProjectDirectory)\obj\v4.5\" 
         RunEachTargetSeparately="true" 
         ContinueOnError="true" 
         />
</Target>

or I'm wrong?

from nettopologysuite.

We need to change all the nuspec files :(

from nettopologysuite.

@FObermaier now it's clear to me also the lack of -client in fwVersion property, as you've posted :(

from nettopologysuite.

When we have fixed the Nuget packages we need to fix the fwVersion property, too

from nettopologysuite.

exactly, now I think I have clear the whole picture... :)

from nettopologysuite.

Can we close this issue?

from nettopologysuite.