Make `belongs_to` an alias of `has_one` about fast_jsonapi HOT 11 CLOSED

@vovimayhem That is a very nice way to refactor some of the repetition we have in the code today. You are right as far JSON:API is concerned i don't think there is any distinction between belongs_to and has_one. I think we should work on this idea.

from fast_jsonapi.

I think I can help with this. I will open a PR soon 👍

from fast_jsonapi.

Hey
I've got a commit with that on another PR (Sorry!)

from fast_jsonapi.

c5295e6

from fast_jsonapi.

No problem. Good work 👍

from fast_jsonapi.

Fixed in #188, @shishirmk can you close?

from fast_jsonapi.

This should be released in version 1.2 of the gem

from fast_jsonapi.

I think this is a big problem when has_one and belongs_to are aliased they are logically different and it should be implemented:

A belongs_to B means A has b_id attribute
A has_one B means B has a_id attribute

Current implementation when you have to provide additional attribute for has_one relation is pretty inconvenient

from fast_jsonapi.

I agree with @ababich and created #257 for consideration

from fast_jsonapi.

@ababich @abevoelker IMHO the direction/cardinality of the association in the database shouldn't be relevant on the serialization part of JSONAPI.

In both cases, you get the associated object's id and type, regardless if the ActiveRecord/ORM model your'e serializing has it implemented as a belongs_to or a has_one. There should be no extra attributes/options required to declare on the serializer.

On an additional note, since we need to traverse the object's association to know the real type of an associated object (via a has_one on the serializer), on most cases the same way to retrieve the associated id (via object.association&.id) will be used.

from fast_jsonapi.

@vovimayhem

fast_jsonapi always expects _id field in model A which is inconvenient in lots of one-to-one associations

for example:

we have base model A and with one-to-one relation with model AHeavyDatails and model AStats

both AHeavyDatails and AStats have a_id field

Having a_id in "extension" models is more scalable, etc. but, anyway, this is existing DB design

to describe this design, belongs_to and has_one are used in all popular ORM which helps to describe this logic

I see no reason why fast_jsonapi cannot follow similar convention

what's more, in terms of API it is very convenient to requiest model A and optionally include AHeavyDatails and/or AStats from example above.

from fast_jsonapi.